Bug 390032 - Add review UI has unnecessary extra padding below the "Accept" button
Summary: Add review UI has unnecessary extra padding below the "Accept" button
Status: RESOLVED FIXED
Alias: None
Product: frameworks-kirigami
Classification: Frameworks and Libraries
Component: general (show other bugs)
Version: 5.42.0
Platform: Neon Linux
: NOR normal
Target Milestone: Not decided
Assignee: Marco Martin
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2018-02-07 18:42 UTC by Nate Graham
Modified: 2018-02-14 16:45 UTC (History)
0 users

See Also:
Latest Commit:
Version Fixed In:


Attachments
Unnecessary extra padding under "Accept" button (213.87 KB, image/png)
2018-02-07 18:42 UTC, Nate Graham
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Nate Graham 2018-02-07 18:42:13 UTC
Created attachment 110414 [details]
Unnecessary extra padding under "Accept" button

See attached screenshot. We should either increase the size of the text field or reduce the size of the pop-up.
Comment 1 Aleix Pol 2018-02-08 01:18:50 UTC
This is an issue in Kirgami. We can also see this in Kirgiami Gallery by going to the "Non Scrollable Page" and pressing the main action button.

Needs investigation as for why.
Comment 2 Nate Graham 2018-02-14 16:45:25 UTC
Git commit cf677c81c7ff5e3db424b6b6784f1050dea99d7f by Nathaniel Graham.
Committed on 14/02/2018 at 16:45.
Pushed by ngraham into branch 'master'.

Eliminate unnecessary bottom padding on OverlaySheets

Summary:
The OverlaySheet already incorporates topMargin and bottomMargin into its height calculation, so we don't need to add any extra padding.

Test Plan:
Tested with Discover's review input sheet.

Before:
{F5710938}

After:
{F5710940}

Also tested in Kirigami Gallery; all pop-ups I could find still looked good.

Reviewers: #kirigami, apol, mart

Reviewed By: #kirigami, mart

Subscribers: plasma-devel

Tags: #kirigami

Differential Revision: https://phabricator.kde.org/D10502

M  +1    -1    src/controls/templates/OverlaySheet.qml

https://commits.kde.org/kirigami/cf677c81c7ff5e3db424b6b6784f1050dea99d7f