Bug 390030 - "Review" button in reviews pop-up smooshed in corner with no padding
Summary: "Review" button in reviews pop-up smooshed in corner with no padding
Status: RESOLVED FIXED
Alias: None
Product: Discover
Classification: Applications
Component: discover (show other bugs)
Version: 5.12.0
Platform: Neon Linux
: NOR normal
Target Milestone: ---
Assignee: Aleix Pol
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2018-02-07 18:34 UTC by Nate Graham
Modified: 2018-02-08 01:48 UTC (History)
0 users

See Also:
Latest Commit:
Version Fixed In: 5.12.1


Attachments
Button in corner with no padding (289.45 KB, image/png)
2018-02-07 18:34 UTC, Nate Graham
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Nate Graham 2018-02-07 18:34:55 UTC
Created attachment 110412 [details]
Button in corner with no padding

See attached screenshot.
Comment 1 Nate Graham 2018-02-07 18:54:03 UTC
Also, the button should probably say "Write a review" to make clear what it will do. "Review" is ambiguous, at least in English (could be a noun, could be an imperative verb).
Comment 2 Aleix Pol 2018-02-08 01:07:52 UTC
Git commit 30575ac706dee8b2ee4ed9a6343922309d414884 by Aleix Pol.
Committed on 08/02/2018 at 01:07.
Pushed by apol into branch 'Plasma/5.12'.

Add some paddings to the Review button

M  +16   -4    discover/qml/ReviewsPage.qml

https://commits.kde.org/discover/30575ac706dee8b2ee4ed9a6343922309d414884
Comment 3 Aleix Pol 2018-02-08 01:09:57 UTC
Git commit de7a1088d5f45a2818437b66707fb406a85ace2a by Aleix Pol.
Committed on 08/02/2018 at 01:09.
Pushed by apol into branch 'master'.

Add elipsis to the Review... button

M  +1    -1    discover/qml/ReviewsPage.qml

https://commits.kde.org/discover/de7a1088d5f45a2818437b66707fb406a85ace2a