Bug 390010 - Multi media widget not able to pause playback
Summary: Multi media widget not able to pause playback
Status: RESOLVED FIXED
Alias: None
Product: Elisa
Classification: Applications
Component: general (show other bugs)
Version: 0.0.81
Platform: openSUSE Linux
: NOR normal
Target Milestone: ---
Assignee: Alexander Stippich
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2018-02-07 15:32 UTC by tneo
Modified: 2018-03-04 16:14 UTC (History)
2 users (show)

See Also:
Latest Commit:
Version Fixed In:
Sentry Crash Report:


Attachments
Pause button gray (11.62 KB, image/png)
2018-02-07 15:32 UTC, tneo
Details
Elisa able to start playback (12.01 KB, image/png)
2018-02-07 15:32 UTC, tneo
Details

Note You need to log in before you can comment on or make changes to this bug.
Description tneo 2018-02-07 15:32:10 UTC
Created attachment 110407 [details]
Pause button gray

When you have Elisa playing music and want to pause using the media playback in the system tray, the Pause button is grayed out. You have to open Elisa to pause playback. When in pause you can resume playback through the widget.
Comment 1 tneo 2018-02-07 15:32:46 UTC
Created attachment 110408 [details]
Elisa able to start playback
Comment 2 Patrick Silva 2018-02-09 00:37:26 UTC
same on Gnome with media player gnome shell extension.
Comment 3 Alexander Stippich 2018-03-04 12:02:02 UTC
Same here, I'm working on a patch
Comment 4 Nicolas Fella 2018-03-04 16:14:28 UTC
Git commit 6e4f63227aff718ee38d6d47b4fd9676ff5be756 by Nicolas Fella.
Committed on 04/03/2018 at 16:14.
Pushed by nicolasfella into branch 'master'.

Fix MPRIS pause

Summary:

According to the MPRIS spec (https://specifications.freedesktop.org/mpris-spec/latest/Player_Interface.html) the value of canPause should not depend on whether the track is currently paused. This patch makes Elisa behave
according to the specification and makes it controllable via #kde_connect

Test Plan: Inspect via DBus Viewer and KDE Connect

Reviewers: #elisa, astippich

Reviewed By: #elisa, astippich

Subscribers: astippich, #elisa

Tags: #elisa

Differential Revision: https://phabricator.kde.org/D11020

M  +1    -1    src/mpris2/mediaplayer2player.cpp

https://commits.kde.org/elisa/6e4f63227aff718ee38d6d47b4fd9676ff5be756