Created attachment 110390 [details] Statistics Window With Marked Failures Some color bars of the lesson statistics bar chart in the lesson practice window are not drawn to its full length. Furthermore sometimes the border line between two bar segments was not drawn. See attached screenshots. Steps to Reproduce: 1) Open a file with vocables of different practice levels in dashboard window. 2) Now statistics main window with its bar chart is displayed. 3) If no paint failure is seen. You can change the window width or open a different file with another amount of vocables. Actual Results: Some of the color bars are not drawn to the end of the chart. Some black border lines between the color bar segments are not drawn. See attached screenshots. Expected Results: All color bars should be drawn to the end of the chart and should have rounded edges on the right and left side. All color bar segments should be separated by black lines (not gray). Version: Build from latest source code from git repository. origin/Applications/17.12
Created attachment 110391 [details] Detail View of Bar Length Failure
Created attachment 110392 [details] Detail View of Border Line Failure in Bar Chart
Created attachment 110393 [details] Detail View of Border Line Failure in Chart Legend
Git commit d3fc379d415b955012f2c2a0d3de1ec2a0727bb5 by Hartmut Riesenbeck. Committed on 15/11/2018 at 19:30. Pushed by hriesenbeck into branch 'master'. Fix color bar painting failures in statistics main window Summary: Some color bars of the bar chart in LessonStatisticsView are not drawn to its full length. The reason are rounding errors in bar segment length calculation. To fix this, all integer values were replaced by floating point variables. Furthermore sometimes the border line between two bar segments was not drawn when constructed with QPainterPath. The relevant QPainterPath operation were replaced by direct drawing operations to the QPainter object. Reviewers: #kde_edu, tcanabrava Reviewed By: #kde_edu, tcanabrava Subscribers: kde-edu, tcanabrava Tags: #kde_edu Differential Revision: https://phabricator.kde.org/D10367 M +17 -17 src/utils.cpp https://commits.kde.org/parley/d3fc379d415b955012f2c2a0d3de1ec2a0727bb5