Created attachment 110334 [details]
lack of shortcut to hide/show preview pane
It would really improve the general workflow if you could have a shortcut to this feature because for example you need to get a good look at a video file before selecting it, on Windows you can do a workaround by opening the file with a video player in the same open file dialog, allowing you to preview the file before selecting it.
Having a shortcut to this pane will allow the user to get a quick preview of the file they are going to select and hide the pane afterwards to get more space available.
Patch submitted: https://phabricator.kde.org/D10314
Git commit 0792ed68923b3c3eac6fd3b9769e83ed2de9842b by Nathaniel Graham.
Committed on 05/02/2018 at 15:07.
Pushed by ngraham into branch 'master'.
Use F11 as the shortcut to toggle the aside preview
Shortcut works and toggles the aside preview.
However, in doing so, another pre-existing bug is triggered: the file dialog doesn't eat the keyboard input, so if the app that spawned it has something bound to F11, you'll erroneously get the "Ambiguous shortcut" message (even though the keystroke is/should be passed only to the file dialog, not the host app). Help solving this would be appreciated.
Reviewers: #frameworks, markg
Reviewed By: markg
Differential Revision: https://phabricator.kde.org/D10314
M +1 -0 src/filewidgets/kdiroperator.cpp
Please ignore the text making reference to an unresolved pre-existing bug; that was fixed with this commit, but I forgot to remove that warning before committing. Sorry for the noise, everyone!