Bug 389836 - Distinguish highlights containing a non-empty popup note inreview pane
Summary: Distinguish highlights containing a non-empty popup note inreview pane
Status: RESOLVED FIXED
Alias: None
Product: okular
Classification: Applications
Component: general (show other bugs)
Version: 1.3.1
Platform: Other Linux
: NOR wishlist
Target Milestone: ---
Assignee: Okular developers
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2018-02-03 16:45 UTC by Simone Gaiarin
Modified: 2018-04-20 17:43 UTC (History)
1 user (show)

See Also:
Latest Commit:
Version Fixed In:
Sentry Crash Report:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Simone Gaiarin 2018-02-03 16:45:25 UTC
Considering the highlight annotations, in the "Reviews" panel all these annotation appears as "Highlight". Sometimes the annotation can contain a popup note as well. It would be useful to mark those annotations that have a non-empty popup note attached. For example, marking them with an asterisk as "Highlight*".

This will simplify finding hidden annotations when there is a lot of highlighted text. 

This may apply to other types of annotations as well.
Comment 1 Albert Astals Cid 2018-04-20 17:43:28 UTC
Git commit cbc6f671e35cc901a8edcc0cadda2459c0277485 by Albert Astals Cid, on behalf of Simone Gaiarin.
Committed on 20/04/2018 at 17:43.
Pushed by aacid into branch 'master'.

Change annotation type name when an annotation is associated to non-empty popup

Summary:
Mark the annotations that contain a non-empty popup. Especially useful to identify annotations that are not meant to contain an annotation as shapes or highlights.

Reviewers: #okular, aacid

Reviewed By: #okular, aacid

Subscribers: rkflx, aacid, ngraham

Tags: #okular

Differential Revision: https://phabricator.kde.org/D10797

M  +15   -1    ui/annotationproxymodels.cpp
M  +2    -0    ui/annotationproxymodels.h
M  +11   -9    ui/guiutils.cpp

https://commits.kde.org/okular/cbc6f671e35cc901a8edcc0cadda2459c0277485