Bug 389796 - Malayalam Inscript chillu, zwj and zwnj not working
Summary: Malayalam Inscript chillu, zwj and zwnj not working
Status: RESOLVED FIXED
Alias: None
Product: kate
Classification: Applications
Component: kwrite (show other bugs)
Version: 16.08
Platform: Debian stable Linux
: NOR normal
Target Milestone: ---
Assignee: KWrite Developers
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2018-02-02 11:52 UTC by jagadees
Modified: 2019-08-27 18:00 UTC (History)
3 users (show)

See Also:
Latest Commit:
Version Fixed In: 5.62


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description jagadees 2018-02-02 11:52:34 UTC
Open kate/kwrite
Select input method as malayalam.
1. Type vd]. it shows ന്.
2. Zwnj not working. JdJ\bz 
3. Type kdk. then press backspace. complete letter get removed. not just one k.

Debian version: Linux 4.9.0-5-amd64 #1 SMP Debian 4.9.65-3+deb9u2 (2018-01-04) x86_64 GNU/Linux
Comment 1 Santhosh Thottingal 2018-02-02 12:20:50 UTC
I can confirm this issue. Observed only Kate/Kwrite. Krunner and other input fields works fine. Kate version  17.04.3

This is a serious regression and prevents Malayalam usage in these editors.
Comment 2 Dominik Haumann 2018-02-04 19:33:20 UTC
@Eike: Could you comment on this? You certainly have more know-how here than us.
Comment 3 jagadees 2018-02-08 17:38:50 UTC
I tried on Leafpad on same machine. These issues are not there in Leafpad.
Comment 4 Christoph Cullmann 2019-08-27 17:03:56 UTC
Git commit 0bf5522434044c61d266fc47bc127fef23d41e7b by Christoph Cullmann, on behalf of Ahmad Samir.
Committed on 27/08/2019 at 17:03.
Pushed by cullmann into branch 'master'.

Mimic QInputControl::isAcceptableInput() when filtering typed characters

Summary:
Move all input characters filtering out of typeChars() to KateViewInternal
and filter the input before sending it to typeChars().

This increases the scope of unicode characters that users can type in ktexteditor.
For more info see:
QChar documentation
http://www.unicode.org/Public/UNIDATA/UnicodeData.txt

This should fix:
- bug 396764 (typing soft-hyphens)
- bug 366424 (typing "private use" unicode characters)
- Hopefully bug 389796 (typing formatting characters such as ZWNJ)
Related: bug 396764, bug 366424

Test Plan:
Test typing a soft-hyphen char (here I used Compose key + minus + minus + space)
For the two other bugs, ask the users to test...

All unit tests passed

Reviewers: #ktexteditor, dhaumann, cullmann

Reviewed By: #ktexteditor, cullmann

Subscribers: kde-frameworks-devel, kwrite-devel

Tags: #kate, #frameworks

Differential Revision: https://phabricator.kde.org/D23472

M  +1    -17   src/document/katedocument.cpp
M  +1    -1    src/document/katedocument.h
M  +85   -12   src/view/kateviewinternal.cpp
M  +5    -0    src/view/kateviewinternal.h

https://commits.kde.org/ktexteditor/0bf5522434044c61d266fc47bc127fef23d41e7b