Bug 389773 - Option to close Spectacle after export or copy the screenshot to clipboard
Summary: Option to close Spectacle after export or copy the screenshot to clipboard
Status: RESOLVED FIXED
Alias: None
Product: Spectacle
Classification: Applications
Component: General (show other bugs)
Version: unspecified
Platform: Other Linux
: NOR wishlist
Target Milestone: ---
Assignee: Boudhayan Gupta
URL:
Keywords: usability
Depends on:
Blocks:
 
Reported: 2018-02-01 21:02 UTC by Patrick Silva
Modified: 2018-02-11 21:35 UTC (History)
1 user (show)

See Also:
Latest Commit:
Version Fixed In: KDE Applications 18.04


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Patrick Silva 2018-02-01 21:02:57 UTC
Rarely I need to keep spectacle opened after to use export or copy to clipboard features.
Therefore I think would be nice if an option to immediately close spectacle after the use of these features is available.
Comment 1 Nate Graham 2018-02-03 21:30:42 UTC
Yep, this is planned. See https://phabricator.kde.org/T7841
Comment 2 Nate Graham 2018-02-10 04:46:57 UTC
I've got a patch going through the review process that adds this feature for copy operations: https://phabricator.kde.org/D10301

Note that you will need to configure Klipper to accept image pastes (Right-click on Klipper icon in system tray > Configure Clipboard > Uncheck "Ignore Images").

Quit after export operations presents more of a challenge and will be done in a separate patch.
Comment 3 Nate Graham 2018-02-11 21:35:14 UTC
Git commit 2b1c8bec0fd1ff6b929eca638264d0649270af5f by Nathaniel Graham.
Committed on 11/02/2018 at 21:25.
Pushed by ngraham into branch 'master'.

(3/3) add option to quit after save or copy operations

Summary:
Part 3 of 3 for {T7841}
FIXED-IN: KDE Applications 18.04

We add a checkbox visible on the main UI to quit Spectacle after save or copy operations. This yields the following benefits:
- We can remove the "Save & Exit" item from the split button
- Users gain the ability to have spectacle quit after copying the image to the clipboard

I tried to make the feature apply to Export operations as well, but that proved to be much more complicated and I decided to abandon that for now and do it later in a subsequent patch.

Test Plan:
{F5691970}

Tested in KDE Neon:
- With "Quit after Copy or Save" unchecked:
-- Save: image is saved
-- Save As: file save dialog shown, image is saved
-- Copy to Clipboard: message is shown, image is copied to clipboard

- With "Quit after Copy or Save" checked:
-- Save: notification shown, Spectacle quits, image is saved
-- Save As: file save dialog shown, notification shown, Spectacle quits, image is saved
-- Copy to Clipboard: image is copied to clipboard (if Klipper is set up to accept images), Spectacle quits

Reviewers: #spectacle, rkflx

Reviewed By: rkflx

Subscribers: rkflx

Differential Revision: https://phabricator.kde.org/D10301

M  +11   -8    doc/index.docbook
M  +7    -1    src/ExportManager.cpp
M  +1    -1    src/ExportManager.h
M  +28   -20   src/Gui/KSMainWindow.cpp
M  +0    -1    src/Gui/KSMainWindow.h
M  +8    -5    src/Gui/KSWidget.cpp
M  +1    -0    src/Gui/KSWidget.h
M  +13   -0    src/SpectacleConfig.cpp
M  +3    -0    src/SpectacleConfig.h

https://commits.kde.org/spectacle/2b1c8bec0fd1ff6b929eca638264d0649270af5f