Bug 389695 - Save action should show notification popup just like Save & Exit
Summary: Save action should show notification popup just like Save & Exit
Alias: None
Product: Spectacle
Classification: Applications
Component: General (show other bugs)
Version: 17.12.1
Platform: Other Linux
: NOR normal
Target Milestone: ---
Assignee: Boudhayan Gupta
Depends on:
Reported: 2018-01-31 14:28 UTC by null
Modified: 2018-02-14 22:48 UTC (History)
1 user (show)

See Also:
Latest Commit:
Version Fixed In:


Note You need to log in before you can comment on or make changes to this bug.
Description null 2018-01-31 14:28:26 UTC
Currently clicking on "Save & Exit" results in an Plasma notification showing a thumbnail and allowing to open the corresponding folder. Hitting "Save", we don't get that.

I don't get why we assume a user knows where the screenshot is saved in one case, but not in the other. Nevertheless, maybe it's not an oversight and the behaviour is intentional (did not check yet).
Comment 1 Nate Graham 2018-02-10 14:17:59 UTC
It's trivial to also show the notification on Save, but the way the code is currently structured, fixing this will trigger Bug 389694 because the notification always emits allDone() when finished, which is supposed to quit Spectacle.

Needs a bit of thought. I'll work on this once if and when my patch to fix Bug 389694 is integrated.
Comment 2 null 2018-02-11 00:01:20 UTC
> I don't get why we assume a user knows where the screenshot is saved
> in one case, but not in the other.
That's the root issue, I guess my title might be a conclusion drawn too fast.

I've got a better idea, how about this:

1. "Quit after Save" unchecked: No notification for "Save" and "Save As".
   (Otherwise it might get annoying.)
2. "Quit after Save" checked: Notification for "Save" and "Save As".
   (As a confirmation of success and a way to access the folder.)
3. Add "Open Screenshots Folder" to our new and shiny "Tools" menu.
   (Opens either ~/Pictures or the last used "Save" / "Save As" folder.)

1. and 2. are implemented in https://phabricator.kde.org/D10301, 3. should not be too hard (I might give it a go, if you want).

I thought about whether to show the folder name in the title, but this is not what Kate or Okular are doing, so I'd rather not diverge.
Comment 3 Nate Graham 2018-02-11 02:36:16 UTC
#3 sounds fine. I'm torn on #s 1 and 2. I can see the utility for casual users, but can also see how it would get annoying for heavy users. Perhaps we could make it a config option that defaults to on, and if you get annoyed, you can turn it off.
Comment 4 null 2018-02-11 20:22:09 UTC
Not sure about that. For #2, you can already configure the notification specific to Spectacle from the notification itself and via systemsettings.

For #1, I would not want to turn in on by default. We could add a second type of notification turned off by default, but then I guess nobody would ever use it. Combining #1 und #2 into a single option is also not really what I want.

Let me know if I should make my patch for #3 a "BUG" or a "CCBUG".

Also, #3 is basically ready. I need to adapt the docbook, but I'll do that once D10295 landed and you rebased D10301 on that.
Comment 5 Nate Graham 2018-02-11 21:30:50 UTC
With https://phabricator.kde.org/D10301, #s 1 and 2 are probably fine for now, so feel free to make it a BUG:
Comment 6 null 2018-02-14 22:48:38 UTC
Git commit 7034b50c5c9ef9c97ec0b7741f3667a93d9a567a by Henrik Fehlauer.
Committed on 14/02/2018 at 22:46.
Pushed by rkflx into branch 'master'.

Add action to open screenshots folder to tools menu

With {nav Quit after Save or Copy} checked, there is a desktop
notification when saving which allows to open the folder containing the
saved screenshot. However, when the user opts to let the window stay
open, only the title will reflect the filename of the saved screenshot.
It's quite hard to know in which folder it was saved and not that easy
to open that folder.

By introducing {nav Tools > Open Screenshots Folder}, usability in that
regard is much-improved. When no screenshot has been saved yet, it will
open the last {nav Save As} folder or the default {nav Save} location
depending on the button state. As soon as a screenshot is saved, the
new action will highlight the new screenshot in the filemanager.

Depends on D10467
Ref T7841

Test Plan:
For {nav Save} and {nav Save As} each, click on new menu entry after
starting Spectacle as well as after saving. Also test everything with
`fish:/` (but beware of Bug 390297).


Reviewers: #spectacle, ngraham

Reviewed By: #spectacle, ngraham

Subscribers: ngraham

Maniphest Tasks: T7841

Differential Revision: https://phabricator.kde.org/D10470

M  +1    -1    doc/index.docbook
M  +11   -1    src/ExportManager.cpp
M  +3    -1    src/ExportManager.h
M  +29   -1    src/Gui/KSMainWindow.cpp
M  +1    -0    src/Gui/KSMainWindow.h