Bug 389617 - Main window too narrow by default
Summary: Main window too narrow by default
Alias: None
Product: systemsettings
Classification: Applications
Component: general (show other bugs)
Version: 5.11.95
Platform: Neon Linux
: NOR normal
Target Milestone: ---
Assignee: Plasma Bugs List
Keywords: usability
Depends on:
Reported: 2018-01-29 20:58 UTC by Nate Graham
Modified: 2018-05-09 15:10 UTC (History)
2 users (show)

See Also:
Latest Commit:
Version Fixed In: 5.13.0


Note You need to log in before you can comment on or make changes to this bug.
Description Nate Graham 2018-01-29 20:58:01 UTC
System Settings' main window is too narrow by default, which makes the text on the front page get squeezed and makes many KCMs get horizontal scrollbars.

This was noticed in a recent review of the Plasma 5.12 beta: http://www.ocsmag.com/2018/01/27/plasma-5-12-long-term-sweetness/

"For example, the system settings [window] opens at a weird initial size and position, with categories text breaking over onto the next line. This does not look pretty, especially since it takes only about 100-200px extra of width to make it look dandy."

We should make it maybe 200px wider by default.
Comment 1 Tore Havn 2018-01-30 22:08:08 UTC
Isn't the KCM supposed to be designed for (and should thus open as) 1024 px x 768 px anyway?
Comment 2 Nate Graham 2018-01-30 22:10:34 UTC
Yeah, this ticket tracks a bug, not a bad design decision. I took a look last night but couldn't find where the size got set. I was pretty sleepy though, and I plan to re-investigate later. If anyone else here with more technical knowledge can also take a look, I would be most grateful!
Comment 3 Scott Harvey 2018-05-09 15:00:56 UTC
Git commit 19712a1d22b2b4055a0ff39bf57fa2fdd41388f3 by Scott Harvey.
Committed on 09/05/2018 at 15:00.
Pushed by sharvey into branch 'master'.

Enlarge default window size. Use (adjusted) calculation in `SizeHint` to determine minimum window width.

Call `setMinimumSize()` at each run to enforce a minimum size. Any enlarged size will be saved and restored via the customary method of saving window geometry.

Test Plan:
- Compile systemsettings with patch
- Launch system settings (systemsettings5)
- Determine that window opens at an appropriate size.
- Close System Settings and reopen; ensure size remains set

To test small or rotated screen sizes:
- Adjust display resolution to a size smaller than the standard target of 1024x700
- System settings window should launch with a margin on all sides (not monopolize entire screen space)

Reviewers: ngraham, mart, davidedmundson, hein, #plasma

Reviewed By: ngraham, davidedmundson, hein, #plasma

Subscribers: davidedmundson, cfeck, zzag, plasma-devel

Tags: #plasma

Differential Revision: https://phabricator.kde.org/D12252

M  +8    -3    app/SettingsBase.cpp