Bug 389602 - Settings page: scrollbar overlaps interactive UI elements
Summary: Settings page: scrollbar overlaps interactive UI elements
Status: RESOLVED FIXED
Alias: None
Product: frameworks-kirigami
Classification: Frameworks and Libraries
Component: general (show other bugs)
Version: Master
Platform: Neon Linux
: NOR normal
Target Milestone: Not decided
Assignee: Marco Martin
URL:
Keywords:
: 390275 (view as bug list)
Depends on:
Blocks:
 
Reported: 2018-01-29 15:28 UTC by Nate Graham
Modified: 2018-02-12 05:26 UTC (History)
2 users (show)

See Also:
Latest Commit:
Version Fixed In: KDE Frameworks 5.43


Attachments
Scrollbar overlaps interactive UI elements (160.06 KB, image/png)
2018-01-29 15:28 UTC, Nate Graham
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Nate Graham 2018-01-29 15:28:00 UTC
Created attachment 110208 [details]
Scrollbar overlaps interactive UI elements

See attached screenshot.

This practice is questionable in general IMHO, but especially inappropriate for Discover's Settings page because there are right-aligned interactive UI elements that start to get covered up when the scrollbar is visible.

It's worth mentioning that this earned us bad press: http://www.ocsmag.com/2018/01/27/plasma-5-12-long-term-sweetness/

"Then, there’s an overlay scrollbar [that] obscures part of the UI. Yup, not just the listed sources entries but also an actual part of the Discover interface!"

Can we give the scrollbar its own separate gutter when it's visible, rather than covering up part of the interface?
Comment 1 Nate Graham 2018-01-29 16:29:48 UTC
Or perhaps we could add margins on both sides of this content the way we do with the App delegates in the list views?
Comment 2 Aleix Pol 2018-01-30 00:19:48 UTC
Both are Kirgiami components, I'd say the delegate should work well with a view with a scrollbar. Moving to Kirigami.
Comment 3 Nate Graham 2018-01-30 00:26:29 UTC
Does this have to be a Kirigami bug? The App delegates work fine here because we build a bit of side padding into the view. Couldn't we do the same on the Settings page?

I mean, it may also be a broader issue that needs to be handled in Kirigami, but I hope it doesn't into an irresolvable discussion of the merits of scrollbars that overlap their content that prevents us from fixing this specific bug.
Comment 4 Marco Martin 2018-01-30 13:21:07 UTC
Git commit aef5ec6e3772fb7c06ff69592122235f26962b4e by Marco Martin.
Committed on 30/01/2018 at 13:20.
Pushed by mart into branch 'master'.

space for the scrollbar

M  +2    -2    src/controls/templates/SwipeListItem.qml

https://commits.kde.org/kirigami/aef5ec6e3772fb7c06ff69592122235f26962b4e
Comment 5 Nate Graham 2018-01-30 16:59:58 UTC
Patch available: https://phabricator.kde.org/D10193
Comment 6 Nate Graham 2018-01-31 16:52:59 UTC
General case already fixed upstream in Kirigami by prior commit. Discover case fixed in https://cgit.kde.org/discover.git/commit/?id=2644e57730309fcfee15d6d414d1c288799cca5d
Comment 7 Nate Graham 2018-02-12 05:26:53 UTC
*** Bug 390275 has been marked as a duplicate of this bug. ***