Bug 389570 - Krita should disable tools for layers a tool cannot work on
Summary: Krita should disable tools for layers a tool cannot work on
Status: RESOLVED FIXED
Alias: None
Product: krita
Classification: Applications
Component: Usability (other bugs)
Version First Reported In: git master (please specify the git hash!)
Platform: Compiled Sources Linux
: NOR normal
Target Milestone: ---
Assignee: Krita Bugs
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2018-01-28 19:56 UTC by lou
Modified: 2019-05-03 13:22 UTC (History)
2 users (show)

See Also:
Latest Commit:
Version Fixed/Implemented In:
Sentry Crash Report:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description lou 2018-01-28 19:56:43 UTC
If you try to draw on a clone layer the brush outline "sticks" to where you clicked.

Not sure how this should behave but this doesn't feel comfortable. If a clone layer should not be drawable on, which makes sense, perhaps there should be some kind of tool black/whitelisting.
Comment 1 Halla Rempt 2018-01-30 08:24:38 UTC
Git commit eca9a7633e1e0ff3b553328fe79bb13aa62432eb by Boudewijn Rempt.
Committed on 30/01/2018 at 08:24.
Pushed by rempt into branch 'master'.

Show a warning when trying to paint on a clone layer

This shows the same warning as when trying to paint with the
freehand tool on a vector layer. Rectangle etc. tools also
should show the warning, but don't yet.

Note that this isn't a complete solution, but generalizing
the message would need changes to the strings, and we're in
string freeze now.

Another option would be to enable/disable tools dependent
on the type of layer selected, but that is a big refactoring,
since tools only react to the type of shape selected at the
moment.

M  +2    -1    libs/ui/tool/kis_tool_freehand.cc
M  +3    -0    libs/ui/tool/kis_tool_paint.cc
M  +2    -1    libs/ui/tool/kis_tool_paint.h

https://commits.kde.org/krita/eca9a7633e1e0ff3b553328fe79bb13aa62432eb
Comment 2 Scott Petrovic 2019-01-07 21:37:44 UTC
We might be able to close this one. I think showing the message like it does now is probably better than disabling in this case.

Usually when things like this are disabled, it creates a user support requests with things like "Krita won't let me paint". I think the message helps educate people "why" the tool won't work.
Comment 3 Halla Rempt 2019-05-03 13:22:28 UTC
I also recently extended this to other tools that cannot work on clone layers.