Bug 389292 - Temporary file is not deleted when I cancel a compression to .arj formats started via Dolphin context menu
Summary: Temporary file is not deleted when I cancel a compression to .arj formats sta...
Status: CONFIRMED
Alias: None
Product: ark
Classification: Applications
Component: plugins (show other bugs)
Version: 23.08.3
Platform: Arch Linux Linux
: NOR normal
Target Milestone: ---
Assignee: Ragnar Thomsen
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2018-01-21 18:59 UTC by Patrick Silva
Modified: 2023-11-14 15:44 UTC (History)
4 users (show)

See Also:
Latest Commit:
Version Fixed In:
Sentry Crash Report:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Patrick Silva 2018-01-21 18:59:19 UTC
open dolphin
right click a folder containing big files
select "compress to..."
enter some file name
select "7zip archive" or "java archive" in "type" drop down
some seconds later, a temp file appears in your file system
click notification icon in your system tray
click stop button aside the progress bar
compression is canceled but the temp file remains in your file system
Comment 1 Viorel-Cătălin Răpițeanu 2019-02-12 17:34:47 UTC
This issue is still reproducing using Ark 18.12.2.
Comment 2 Frederick Zhang 2020-02-13 12:16:22 UTC
I can confirm this using Ark 19.12.2.
Comment 3 Bug Janitor Service 2022-02-03 17:41:34 UTC
A possibly relevant merge request was started @ https://invent.kde.org/utilities/ark/-/merge_requests/95
Comment 4 Méven Car 2022-02-04 08:43:18 UTC
https://invent.kde.org/utilities/ark/-/merge_requests/95 will fix most plugins.

Other patch for the libzip plugin:
https://invent.kde.org/utilities/ark/-/merge_requests/94

The plugin I could identify that would not work is clipzip (the java case here).
For the plugin clizip we could use --temp-path but which temp path to use ? I would guess a hidden unique dir in the destination dir.
Comment 5 Méven Car 2022-02-05 08:44:22 UTC
Git commit e1c19e2222d1ce364d7ec5b4b275ffb3aab0d234 by Méven Car.
Committed on 05/02/2022 at 08:41.
Pushed by meven into branch 'release/21.12'.

CreateJob: Clean up temp file after cancellation

Works for most cli plugins except zip.

M  +14   -1    kerfuffle/jobs.cpp

https://invent.kde.org/utilities/ark/commit/e1c19e2222d1ce364d7ec5b4b275ffb3aab0d234
Comment 6 Méven Car 2022-02-07 13:46:46 UTC
Git commit 6ffd4344f7913eb3d9b3978f4b91a38f9d2db1df by Méven Car.
Committed on 07/02/2022 at 10:59.
Pushed by meven into branch 'release/21.12'.

libzip: Implement proper cancelation, using libzip 1.6

M  +5    -0    CMakeLists.txt
A  +6    -0    config.h.in
M  +19   -4    plugins/libzipplugin/libzipplugin.cpp
M  +1    -0    plugins/libzipplugin/libzipplugin.h

https://invent.kde.org/utilities/ark/commit/6ffd4344f7913eb3d9b3978f4b91a38f9d2db1df
Comment 7 Patrick Silva 2022-05-20 00:06:39 UTC
cannot reproduce with 7zip format, java format is not available on my Ark 22.04.1. Was support for java format removed?

Operating System: Arch Linux
KDE Plasma Version: 5.24.90
KDE Frameworks Version: 5.94.0
Qt Version: 5.15.4
Graphics Platform: Wayland
Comment 8 Méven Car 2022-05-20 06:22:45 UTC
(In reply to Patrick Silva from comment #7)
> cannot reproduce with 7zip format, java format is not available on my Ark
> 22.04.1. Was support for java format removed?
> 
> Operating System: Arch Linux
> KDE Plasma Version: 5.24.90
> KDE Frameworks Version: 5.94.0
> Qt Version: 5.15.4
> Graphics Platform: Wayland

You need `unzip` and `zip` installed on your machine and the ark `clizipplugin` plugin installed to have support for java archives.

Unfortunately for this plugin cleaning leftover files is a bit more complicated.
Comment 9 Patrick Silva 2022-05-20 12:12:13 UTC
Can confirm that java format is available on my system after installing zip package. unzip was already installed.
Thank you Méven. :)
Comment 10 Méven Car 2022-05-20 21:18:01 UTC
(In reply to Patrick Silva from comment #9)
> Can confirm that java format is available on my system after installing zip
> package. unzip was already installed.
> Thank you Méven. :)

The thing is the c++ zipplugin could be used for any zip based archive, it is just a metadata issue.
Comment 11 Patrick Silva 2022-11-12 11:43:58 UTC
Can also reproduce with .arj format.
Comment 12 Patrick Silva 2023-11-14 15:44:30 UTC
Cannot reproduce with .jar format anymore. Cannot test .arj because currently the compression to this format is broken.