Bug 389263 - Account creation panel closes after entering email address if pressing enter to continue
Summary: Account creation panel closes after entering email address if pressing enter ...
Status: RESOLVED FIXED
Alias: None
Product: libkgapi
Classification: Frameworks and Libraries
Component: General (show other bugs)
Version: unspecified
Platform: Other Linux
: NOR normal
Target Milestone: ---
Assignee: Daniel Vrátil
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2018-01-20 19:17 UTC by Björn Bidar (Thaodan)
Modified: 2018-02-01 06:45 UTC (History)
1 user (show)

See Also:
Latest Commit:
Version Fixed In:
Sentry Crash Report:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Björn Bidar (Thaodan) 2018-01-20 19:17:29 UTC
I tried used using the google account ressource after the recent update of libkgapi.
But when I enter my email address and continue the panel just closes and stays at the enter pw/account selector page.

The old page works thow
https://support.google.com/accounts/answer/7338427?co=GENIE.Platform%3DAndroid&hl=en&oco=1
Comment 1 Björn Bidar (Thaodan) 2018-01-20 20:01:54 UTC
Adding an email account works, but not contacts/calendar.
Comment 2 David Kahles 2018-01-31 07:37:06 UTC
Which distro are you using?

There was a bugfix applied recently, which tried to fix the problem of a not working authentication for some people. But it appears to have created problems for others.

Unfortunately i don't know the source of the problem, but a few days ago, we changed the authentication process again, using a more robust method. Would you try to compile libkgapi yourself and check, whether the second change fixes your problem?

I can give you detailed instructions if needed.
Comment 3 Björn Bidar (Thaodan) 2018-01-31 08:09:08 UTC
I'm using Arch Linux.
I tried it a few minutes ago. I build libkgapi my self on 28th of Januar from git.
The issue is the same. 
Logs with private stuff stripped:
https://paste.kde.org/pzwgcayp4
Comment 4 David Kahles 2018-01-31 10:26:14 UTC
Can you precisely describe the steps you take, and the pages (both, webpages and kaddressbook/korganizer windows) you see? I don't fully understand your problem. Making screenshots or a video might also help.
Comment 5 David Kahles 2018-01-31 10:27:05 UTC
(In reply to Thaodan from comment #3)
> I'm using Arch Linux.
> I tried it a few minutes ago. I build libkgapi my self on 28th of Januar
> from git.
> The issue is the same. 
> Logs with private stuff stripped:
> https://paste.kde.org/pzwgcayp4

Is this the full log, until the end? Or are there more log messages?
Comment 6 Björn Bidar (Thaodan) 2018-01-31 10:37:12 UTC
No thats are all messages posted by the ressource.

What I do:

1. open Kontact
2. go to contacts/calendar (doesn't matter).
3. add new Adressbook/Calendar
4. Select Google Calendar/Google contacts
4. Click on add.
5. the embed webpage opens, I enter my accountname.
5. the frame closes after pressing enter.
Comment 7 David Kahles 2018-01-31 10:54:49 UTC
I think you are experiencing a focus issue. This is not related to the recent change, but should be fixed too.

Please try to not use the enter key, but instead use the mouse to click the "next" button.
Comment 8 Björn Bidar (Thaodan) 2018-01-31 11:54:45 UTC
Yes thats exactly the issue, pressing next with the mouse helps.
but which commit where should fix that?
Comment 9 David Kahles 2018-02-01 06:45:23 UTC
Git commit 1ad3e82403e2f01e9b44e5e7daa2324c22d66603 by David Kahles.
Committed on 01/02/2018 at 06:45.
Pushed by davidk into branch 'Applications/17.12'.

Fix oauth focus

Summary:
Set the focus to the webview. Previously, if you entered an e-mail address
and pressed enter, it would have closed the webview, because the cancel button
is the default button. I think this is a QT bug, so I opened a QT bugreport.

Test Plan:
- In KMail, the focus works now
- In KOrganizer, the focus works now

Reviewers: dvratil, mlaurent

Reviewed By: dvratil

Subscribers: #kde_pim

Tags: #kde_pim

Differential Revision: https://phabricator.kde.org/D10206

M  +3    -0    src/core/authjob.cpp
M  +1    -0    src/core/ui/authwidget.cpp

https://commits.kde.org/libkgapi/1ad3e82403e2f01e9b44e5e7daa2324c22d66603