Bug 389208 - Request addition of "Lens" to Tool-Tips (Icon Items)
Summary: Request addition of "Lens" to Tool-Tips (Icon Items)
Status: RESOLVED FIXED
Alias: None
Product: digikam
Classification: Applications
Component: Setup-Tooltips (show other bugs)
Version: 5.8.0
Platform: openSUSE Linux
: NOR wishlist
Target Milestone: ---
Assignee: Digikam Developers
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2018-01-19 14:43 UTC by Paul
Modified: 2018-01-22 12:46 UTC (History)
2 users (show)

See Also:
Latest Commit:
Version Fixed In: 5.9.0
Sentry Crash Report:


Attachments
lensinfo.png (160.21 KB, image/png)
2018-01-19 20:20 UTC, Maik Qualmann
Details
lensinfo2.png (164.13 KB, image/png)
2018-01-19 20:41 UTC, Maik Qualmann
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Paul 2018-01-19 14:43:53 UTC
It would be quite useful to have "Lens" (text description of the type of lens used) as an available Tool-Tip item under "Icon Items"/"Photograph Information".
Comment 1 caulier.gilles 2018-01-19 16:28:53 UTC
This kind of incformation to display in tooltip is problematic.

Typically, Lens details can be multiple for a same Lens ID decoded in Exif Makernotes. currently this information is show with "|" separator when more than one lens is possible with the same ID. The result is a very long string which cannot be suitable in Tooltips, because this will be truncated.

A work around can be possible in low level Exiv2 shared lib used by digiKam to catch the Lens description where a more indeed work must be done to be more precise about the right lens used while shooting photo. ExifTool is able to perform this job, but not yet Exiv2.

This problem must be reported in Exiv2 bugzilla for a future improvement (perhaps the entry already exists, i don't know).

Gilles Caulier
Comment 2 Paul 2018-01-19 18:13:35 UTC
(In reply to caulier.gilles from comment #1)
> This kind of incformation to display in tooltip is problematic.
> 
> Typically, Lens details can be multiple for a same Lens ID decoded in Exif
> Makernotes. currently this information is show with "|" separator when more
> than one lens is possible with the same ID. The result is a very long string
> which cannot be suitable in Tooltips, because this will be truncated.
> 
OK... I wasn't aware of the possibility of multiple lens with the same ID

Would be possible to implement the "Lens" tool-tip as an experimental feature, and if it's found one or more (users) lenses are being misidentified, for the user to then create a identification file "~/.exiv2" as outlined here:

http://dev.exiv2.org/projects/exiv2/wiki/Lens_Recognition_in_Exiv2_v026_(and_later)/ 

and further discussed in this issue:

http://dev.exiv2.org/issues/1212
Comment 3 Maik Qualmann 2018-01-19 20:20:13 UTC
Created attachment 110000 [details]
lensinfo.png

This is a small test of what it would look like. As you can see, there are only a few signs left and with this lens the type is still unknown by the abbreviation. A two line view might be possible.

Maik
Comment 4 Maik Qualmann 2018-01-19 20:41:59 UTC
Created attachment 110001 [details]
lensinfo2.png

Already more to read from the lens name, but the line break should be made only while spaces...

Maik
Comment 5 Paul 2018-01-20 13:04:12 UTC
Yes, I see the secondary problem of a long descriptive name being truncated, I'd not considered that.

I like the two line idea, (with the line break occurring only on white space, or hyphen, perhaps).

Personally I'd like to see it implemented, I feel it would be a worthwhile addition even with it's limitations.

Thanks for your consideration and time :)
Comment 6 Maik Qualmann 2018-01-20 22:38:40 UTC
Git commit 0afd5e05e83c25fb2e1ec131d8b4dddc816625bd by Maik Qualmann.
Committed on 20/01/2018 at 22:37.
Pushed by mqualmann into branch 'master'.

show lens information in the tooltip
FIXED-IN: 5.9.0

M  +2    -1    NEWS
M  +27   -0    app/utils/tooltipfiller.cpp
M  +2    -0    libs/settings/applicationsettings.cpp
M  +3    -0    libs/settings/applicationsettings.h
M  +3    -0    libs/settings/applicationsettings_p.cpp
M  +2    -0    libs/settings/applicationsettings_p.h
M  +11   -0    libs/settings/applicationsettings_tooltips.cpp
M  +17   -7    utilities/setup/setuptooltip.cpp

https://commits.kde.org/digikam/0afd5e05e83c25fb2e1ec131d8b4dddc816625bd
Comment 7 Maik Qualmann 2018-01-21 10:59:12 UTC
Git commit adc32f7be28bdd2fd3737ed3a005e1909cae0b2e by Maik Qualmann.
Committed on 21/01/2018 at 10:57.
Pushed by mqualmann into branch 'master'.

show lens information in the import tooltip

M  +26   -0    utilities/importui/items/importtooltipfiller.cpp
M  +18   -0    utilities/importui/main/importsettings.cpp
M  +3    -0    utilities/importui/main/importsettings.h
M  +14   -4    utilities/setup/setuptooltip.cpp

https://commits.kde.org/digikam/adc32f7be28bdd2fd3737ed3a005e1909cae0b2e
Comment 8 Maik Qualmann 2018-01-21 12:00:15 UTC
Git commit 15ccae35c8ff834c1f1db5d609a3fbcac79623d5 by Maik Qualmann.
Committed on 21/01/2018 at 11:58.
Pushed by mqualmann into branch 'master'.

show lens information in the showFoto tooltip

M  +15   -0    showfoto/main/showfotosettings.cpp
M  +3    -0    showfoto/main/showfotosettings.h
M  +9    -0    showfoto/setup/showfotosetuptooltip.cpp
M  +27   -0    showfoto/thumbbar/showfototooltipfiller.cpp
M  +1    -0    utilities/importui/items/importtooltipfiller.cpp

https://commits.kde.org/digikam/15ccae35c8ff834c1f1db5d609a3fbcac79623d5
Comment 9 Paul 2018-01-22 12:24:06 UTC
Thanks, appreciated. :)
Comment 10 caulier.gilles 2018-01-22 12:46:26 UTC
Note : you can test the new tooltips feature with the Linux AppImage bundle 5.9.0 :

https://files.kde.org/digikam/

Gilles Caulier