Bug 389174 - When a filter layer is placed above a group of image layers, only the area affected by the filter layer is exported.
Summary: When a filter layer is placed above a group of image layers, only the area af...
Status: RESOLVED FIXED
Alias: None
Product: krita
Classification: Applications
Component: Filter Layers (other bugs)
Version First Reported In: 4.0.0-beta.1
Platform: Manjaro Linux
: NOR normal
Target Milestone: ---
Assignee: Dmitry Kazakov
URL:
Keywords: regression, release_blocker, triaged
Depends on:
Blocks:
 
Reported: 2018-01-18 19:17 UTC by Tony Sharp
Modified: 2018-02-07 01:49 UTC (History)
2 users (show)

See Also:
Latest Commit:
Version Fixed/Implemented In:
Sentry Crash Report:


Attachments
Example. (1.09 MB, application/x-krita)
2018-01-18 19:17 UTC, Tony Sharp
Details
attachment-16498-0.html (2.29 KB, text/html)
2018-02-07 01:49 UTC, Tony Sharp
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Tony Sharp 2018-01-18 19:17:10 UTC
Created attachment 109973 [details]
Example.

The bug can be replicated with the following steps:
- Load an image.
- Assign image layer to a group.
- Add a filter layer (Levels) above the group.
- Save image in native image format and Krita (kra) format.
Comment 1 mvowada 2018-01-19 12:32:41 UTC
Hi. I'm able to reproduce this bug. In my case, it happens also when the file layer is not grouped (tested on Ubuntu 14.04 using Krita 4.0.0-beta1.1.appimage).

(I thought that filter layers ignored selections, but it seems I can't find evidences on the documentation pages...)
Comment 2 Halla Rempt 2018-01-24 09:27:33 UTC
I guess this is another place where the cloning of the image for saving is incomplete. Maybe for single-layer export formats, we should just copy the projection.
Comment 3 Dmitry Kazakov 2018-02-06 14:00:07 UTC
Git commit 0c33e5197a0038256b0c5851e25497d50406a3d4 by Dmitry Kazakov.
Committed on 06/02/2018 at 13:59.
Pushed by dkazakov into branch 'master'.

Fix cloning of KisSelectionBasedLayer

'useSelectionInProjection' should also be copied, otherwise
the layer behaves weirdly.

M  +8    -2    libs/image/kis_selection_based_layer.cpp

https://commits.kde.org/krita/0c33e5197a0038256b0c5851e25497d50406a3d4
Comment 4 Dmitry Kazakov 2018-02-06 14:03:31 UTC
Hi, Tony!

Thank for a nice image for reproducing the bug! It was pleasure to work on the fix for the bug :)
Comment 5 Tony Sharp 2018-02-07 01:49:43 UTC
Created attachment 110382 [details]
attachment-16498-0.html

You're welcome, Dmitry! I'm glad I could help.

- Tony

________________________________
From: Dmitry Kazakov <bugzilla_noreply@kde.org>
Sent: Tuesday, February 6, 2018 8:03:31 AM
To: subtlearray@outlook.com
Subject: [krita] [Bug 389174] When a filter layer is placed above a group of image layers, only the area affected by the filter layer is exported.

https://eur01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fbugs.kde.org%2Fshow_bug.cgi%3Fid%3D389174&data=02%7C01%7C%7C3a83399abd0d4eefd7e208d56d6a6947%7C84df9e7fe9f640afb435aaaaaaaaaaaa%7C1%7C0%7C636535226149367422&sdata=z%2Fz8aP23A11%2B%2Bju9I1cQImjonFFb9KJlEUlcRA9PxEc%3D&reserved=0

--- Comment #4 from Dmitry Kazakov <dimula73@gmail.com> ---
Hi, Tony!

Thank for a nice image for reproducing the bug! It was pleasure to work on the
fix for the bug :)

--
You are receiving this mail because:
You reported the bug.