Bug 389136 - Some songs are not shown(git)
Summary: Some songs are not shown(git)
Status: RESOLVED WORKSFORME
Alias: None
Product: Elisa
Classification: Applications
Component: general (show other bugs)
Version: unspecified
Platform: Other Linux
: NOR normal
Target Milestone: ---
Assignee: Matthieu Gallien
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2018-01-17 23:21 UTC by Ivan S
Modified: 2019-09-04 04:33 UTC (History)
3 users (show)

See Also:
Latest Commit:
Version Fixed In:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Ivan S 2018-01-17 23:21:27 UTC
If a song does not have an associated album, it will not appear in Elisa.
Comment 1 Matthieu Gallien 2018-01-18 20:29:25 UTC
I thought it was working. Could you check if they appear in the "all tracks" view ?
Thanks
Comment 2 Ivan S 2018-01-18 20:32:30 UTC
Only items with an associated item appear in "all tracks." I have 4 mp3s in my Music folder; only one shows up.
Comment 3 Alexander Stippich 2018-04-07 18:37:32 UTC
I've hit the same bug and the code clearly only gives valid metadata if an album has been found
Comment 4 Diego Gangl 2018-04-23 15:20:07 UTC
I came here to mention post this bug too. MP3s without an album don't show up at all.
Comment 5 Alexander Stippich 2018-10-12 18:56:04 UTC
Git commit baaa5386311384dc9dc3b6d221493a9b244fb0ca by Alexander Stippich.
Committed on 12/10/2018 at 18:55.
Pushed by astippich into branch 'master'.

allow metadata of tracks without album and tracknumber in database

Summary:
remove not null constrain for database and change sql query to allow tracks with more incomplete metadata
Related: bug 393118, bug 396607

Test Plan: tests pass as before, new tests pass as well

Reviewers: mgallien

Reviewed By: mgallien

Tags: #elisa

Differential Revision: https://phabricator.kde.org/D13685

M  +192  -2    autotests/databaseinterfacetest.cpp
M  +43   -39   src/databaseinterface.cpp

https://commits.kde.org/elisa/baaa5386311384dc9dc3b6d221493a9b244fb0ca
Comment 6 Alexander Stippich 2018-11-17 09:11:55 UTC
Git commit 4ace01ef214d1c99b55fdc64392efb7d05faada2 by Alexander Stippich.
Committed on 17/11/2018 at 09:11.
Pushed by astippich into branch 'master'.

add a test for tracks with empty artist tag in database

Summary:
adds a test for tracks with empty artist tag in database, currently failing
Related: bug 393118, bug 396607

Reviewers: mgallien

Reviewed By: mgallien

Tags: #elisa

Differential Revision: https://phabricator.kde.org/D16193

M  +95   -0    autotests/databaseinterfacetest.cpp

https://commits.kde.org/elisa/4ace01ef214d1c99b55fdc64392efb7d05faada2
Comment 7 Matthieu Gallien 2018-11-25 19:57:08 UTC
Git commit fde30aa8c9df54eae1a4cfa04891bd9102fdc160 by Matthieu Gallien.
Committed on 25/11/2018 at 19:26.
Pushed by mgallien into branch 'master'.

improve database performance and reliability

Summary:
let database test addOneTrackWithoutAlbumArtist have a file database

let the numeric unique id starts at 1 instead of 2

let fix warnings from QtCreator in database tests

DatabaseInterface: does not emit track changed signals for newly added

album artist name is directly a foreign key in Albums

should help to ensure greater reliability

lists of authors where not working so let's scrap this

use the unique fields of Albums for foreign key in Tracks

remove TracksArtists Table

no longer store tracks count and single disc states in albums table

reduce overhead from AllTracksModel

reduce overhead of AllAlbumsModel and make it synchronous

do not list files too early from Baloo

keep all files discovered from a source and fix a minor related issue

add a test for DatabaseInterface::askRestoredTracks

add albums and artists cache and improve cache usage

improve management of files not modified since last scan of music files
Related: bug 396607, bug 396840

Test Plan: tests are OK and Elisa application is still working

Reviewers: astippich, januz

Reviewed By: astippich

Tags: #elisa

Differential Revision: https://phabricator.kde.org/D16302


https://commits.kde.org/elisa/fde30aa8c9df54eae1a4cfa04891bd9102fdc160
Comment 8 Nate Graham 2019-08-05 16:43:56 UTC
Can you try the latest version of Elisa (or git master, that would be even better) and see if those commits fixed the problem for you? Thanks!
Comment 9 Bug Janitor Service 2019-08-20 04:33:09 UTC
Dear Bug Submitter,

This bug has been in NEEDSINFO status with no change for at least
15 days. Please provide the requested information as soon as
possible and set the bug status as REPORTED. Due to regular bug
tracker maintenance, if the bug is still in NEEDSINFO status with
no change in 30 days the bug will be closed as RESOLVED > WORKSFORME
due to lack of needed information.

For more information about our bug triaging procedures please read the
wiki located here:
https://community.kde.org/Guidelines_and_HOWTOs/Bug_triaging

If you have already provided the requested information, please
mark the bug as REPORTED so that the KDE team knows that the bug is
ready to be confirmed.

Thank you for helping us make KDE software even better for everyone!
Comment 10 Bug Janitor Service 2019-09-04 04:33:12 UTC
This bug has been in NEEDSINFO status with no change for at least
30 days. The bug is now closed as RESOLVED > WORKSFORME
due to lack of needed information.

For more information about our bug triaging procedures please read the
wiki located here:
https://community.kde.org/Guidelines_and_HOWTOs/Bug_triaging

Thank you for helping us make KDE software even better for everyone!