Bug 388916 - Install button doesn't disable or become something else during installation of Snap app
Summary: Install button doesn't disable or become something else during installation o...
Status: RESOLVED FIXED
Alias: None
Product: Discover
Classification: Applications
Component: Snap Backend (show other bugs)
Version: unspecified
Platform: Other Linux
: NOR normal
Target Milestone: ---
Assignee: Aleix Pol
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2018-01-13 16:39 UTC by Nate Graham
Modified: 2018-01-15 21:28 UTC (History)
0 users

See Also:
Latest Commit:
Version Fixed In:


Attachments
Clicked the install button three times (124.16 KB, image/png)
2018-01-13 16:39 UTC, Nate Graham
Details
The button still doesn't disable (302.75 KB, video/webm)
2018-01-15 19:32 UTC, Nate Graham
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Nate Graham 2018-01-13 16:39:49 UTC
Created attachment 109838 [details]
Clicked the install button three times

Discover with the Snap backend compiled from git master on KDE Neon

When I click the install button to install a Snap app, it doesn't get disabled or turn into something else during installation. As a result, you can click it multiple times, with odd results. See attached screenshot.
Comment 1 Aleix Pol 2018-01-15 02:18:35 UTC
Git commit 3193c6f19b96425278915f045a3ee662cb6093bc by Aleix Pol.
Committed on 15/01/2018 at 02:14.
Pushed by apol into branch 'master'.

Report progress on snaps

M  +8    -1    libdiscover/backends/SnapBackend/SnapTransaction.cpp

https://commits.kde.org/discover/3193c6f19b96425278915f045a3ee662cb6093bc
Comment 2 Nate Graham 2018-01-15 02:45:31 UTC
Hmm, even with that commit, the Install button still doesn't change or deactivate, so you can still click it multiple times.
Comment 3 Aleix Pol 2018-01-15 18:33:15 UTC
Git commit c947d6f9571b72632bb2b50e29b62e89bbb4fab7 by Aleix Pol.
Committed on 15/01/2018 at 18:29.
Pushed by apol into branch 'Plasma/5.12'.

snap: Set the downloading status to the transaction

Otherwise the TransactionListener (hence the button) doesn't consider it
active

M  +1    -1    libdiscover/backends/SnapBackend/SnapTransaction.cpp

https://commits.kde.org/discover/c947d6f9571b72632bb2b50e29b62e89bbb4fab7
Comment 4 Nate Graham 2018-01-15 19:32:58 UTC
Created attachment 109888 [details]
The button still doesn't disable

Hmm, either something is weird with my Snap installation, or this still isn't fixed as of that commit. I'm attaching a video.
Comment 5 Nate Graham 2018-01-15 21:28:10 UTC
Sorry, I hadn't realized that the work was done on the 5.12 branch, and I was still building from master. I can confirm that the button works properly now. Sorry for the noise!