Bug 388904 - "Uniform Scaling" does not work on single shapes
Summary: "Uniform Scaling" does not work on single shapes
Status: RESOLVED FIXED
Alias: None
Product: krita
Classification: Applications
Component: Tools (show other bugs)
Version: 4.0.0-beta.1
Platform: Appimage Linux
: NOR normal
Target Milestone: ---
Assignee: Dmitry Kazakov
URL:
Keywords: release_blocker
Depends on:
Blocks:
 
Reported: 2018-01-13 12:57 UTC by mvowada
Modified: 2018-02-23 17:19 UTC (History)
1 user (show)

See Also:
Latest Commit: https://commits.kde.org/krita/637915327b08e15407023cc6d95de9718a1f8bff
Version Fixed In:

Attachments
Add an attachment

Note You need to log in before you can comment on or make changes to this bug.
Description mvowada 2018-01-13 12:57:48 UTC 
(Ubuntu 14.04 - Krita 4.0.0-beta1.1)

"Tool Options > Geometry > Uniform Scaling" option when enabled, seems to do nothing. Steps:

1) select a vector shape
2) change the width/height of the shape by going to "Tool Options > Geometry" and with the "Uniform Scaling" option checked

Actual Results: "Uniform Scaling" seems to be ineffective
Expected Results: change the vector size in accordance with "Uniform Scaling" option
Comment 1 Halla Rempt 2018-01-17 12:43:18 UTC 
It only seems to work for grouped shapes, or when multiple shapes are selected.
Comment 2 Dmitry Kazakov 2018-02-23 16:30:46 UTC 
According to the initial design, Uniform Scaling works only when changing size of the shape using the input boxes on the widget :)

I should check if it is possible to extend it to the mouse-drag action
Comment 3 Dmitry Kazakov 2018-02-23 17:16:45 UTC 
Git commit 637915327b08e15407023cc6d95de9718a1f8bff by Dmitry Kazakov.
Committed on 23/02/2018 at 17:16.
Pushed by dkazakov into branch 'master'.

Let Uniform Scaling mode work when dragging shapes with mouse

M  +2    -2    plugins/tools/defaulttool/defaulttool/DefaultTool.cpp
M  +5    -0    plugins/tools/defaulttool/defaulttool/DefaultToolGeometryWidget.cpp
M  +2    -0    plugins/tools/defaulttool/defaulttool/DefaultToolGeometryWidget.h
M  +8    -3    plugins/tools/defaulttool/defaulttool/DefaultToolTabbedWidget.cpp
M  +5    -0    plugins/tools/defaulttool/defaulttool/DefaultToolTabbedWidget.h
M  +4    -3    plugins/tools/defaulttool/defaulttool/ShapeResizeStrategy.cpp
M  +3    -1    plugins/tools/defaulttool/defaulttool/ShapeResizeStrategy.h

https://commits.kde.org/krita/637915327b08e15407023cc6d95de9718a1f8bff
Comment 4 mvowada 2018-02-23 17:19:57 UTC 
(In reply to Dmitry Kazakov from comment #3)
> Git commit 637915327b08e15407023cc6d95de9718a1f8bff by Dmitry Kazakov.
> Committed on 23/02/2018 at 17:16.
> Pushed by dkazakov into branch 'master'.
> 
> Let Uniform Scaling mode work when dragging shapes with mouse
> 
> M  +2    -2    plugins/tools/defaulttool/defaulttool/DefaultTool.cpp
> M  +5    -0   
> plugins/tools/defaulttool/defaulttool/DefaultToolGeometryWidget.cpp
> M  +2    -0   
> plugins/tools/defaulttool/defaulttool/DefaultToolGeometryWidget.h
> M  +8    -3   
> plugins/tools/defaulttool/defaulttool/DefaultToolTabbedWidget.cpp
> M  +5    -0   
> plugins/tools/defaulttool/defaulttool/DefaultToolTabbedWidget.h
> M  +4    -3    plugins/tools/defaulttool/defaulttool/ShapeResizeStrategy.cpp
> M  +3    -1    plugins/tools/defaulttool/defaulttool/ShapeResizeStrategy.h
> 
> https://commits.kde.org/krita/637915327b08e15407023cc6d95de9718a1f8bff

Thank you!