Bug 388806 - Calling popup palette with certain zooming rate cause the zoom rate to jump slightly
Summary: Calling popup palette with certain zooming rate cause the zoom rate to jump s...
Status: RESOLVED FIXED
Alias: None
Product: krita
Classification: Applications
Component: OpenGL Canvas (show other bugs)
Version: 4.0.0-beta.1
Platform: Other Linux
: NOR normal
Target Milestone: ---
Assignee: Scott Petrovic
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2018-01-11 14:05 UTC by Tyson Tan
Modified: 2018-01-18 13:44 UTC (History)
2 users (show)

See Also:
Latest Commit:
Version Fixed In:
Sentry Crash Report:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Tyson Tan 2018-01-11 14:05:31 UTC
In Krita 4.0 beta 1, when the canvas has certain zooming rate, like 17%, 33% (using keyboard +/-), calling popup palette with right click causes the zoom rate to jump a bit, but the number in status bar doesn't reflect that. The status bar will only update after an extra keyboard +/- command after closing the popup palette.

Zoom rate like 25% and 50% are not affected.

Tested with Manjaro Gnome 17.1.1, krita-4.0.0-beta1.1-x86_64.appimage, OpenGL enabled. AMD Firepro W5100 with open source driver.
Comment 1 Halla Rempt 2018-01-11 14:22:11 UTC
Is that with a right-click with a stylus or a mouse?
Comment 2 wolthera 2018-01-11 14:24:16 UTC
I can reproduce it with master, though for me the pop-up palette is set to a hotkey, and not to right-click.
Comment 3 Tyson Tan 2018-01-11 15:55:26 UTC
Both stylus and mouse right click can trigger this. It seems that only 25%, 50%, 100% zoom rate are unaffected.
Comment 4 Halla Rempt 2018-01-17 13:07:34 UTC
I'm pretty sure that this is some kind of rounding going on after commit

commit 41ad9e5894199d857a77d7f3387ef0914427b840
Author: Scott Petrovic <scottpetrovic@gmail.com>
Date:   Mon Feb 13 17:51:59 2017 -0600

    make sure slider is in the right position when the 100 percent zoom button is pressed
Comment 5 Scott Petrovic 2018-01-18 13:44:18 UTC
Git commit e67ed09bd7df38a2e853630c9dba41110007308c by Scott Petrovic.
Committed on 18/01/2018 at 13:43.
Pushed by scottpetrovic into branch 'master'.

M  +3    -0    libs/ui/kis_popup_palette.cpp

https://commits.kde.org/krita/e67ed09bd7df38a2e853630c9dba41110007308c