Created attachment 109779 [details] plasma-pa with Breeze Dark plasma-pa really looks ugly with dark theme on settings window. ISSUES: - Checkbox used from plasma theme. Why not used Qt checkbox from theme engine? - Menuitem style hardcoded and impossible readable with dark theme. STEPS FOR REPRODUCE: - Set Breeze Dark style on systemsettings - Open plasma-pa settings window, set tab Volume-Additional-Profile and tap on menuitem. Preview attached. More info here: https://github.com/PapirusDevelopmentTeam/adapta-kde/issues/34 https://github.com/PapirusDevelopmentTeam/adapta-kde/issues/26 KDE Neon User Edition Plasma 5.11.5 KDE Frameworks 5.41 Qt 5.9.3
Hi, I am a long-time KDE user who wants to get involved in the development and solve this bug. Would this be a good 'first-bug' to start with? Can someone please provide a bit more information on what needs to be done?
https://phabricator.kde.org/D9784 https://phabricator.kde.org/D9785
Git commit 84a370ce2c3ac48be9e8745a93cd347bba463323 by Kai Uwe Broulik. Committed on 15/01/2018 at 09:31. Pushed by broulik into branch 'master'. [ConfigModule] Re-use QML context and engine if any In case the ConfigModule is created within a QML context, re-use it and its engine instead of creating a shared QML object that might use a different engine. Differential Revision: https://phabricator.kde.org/D9784 M +16 -2 src/quickaddons/configmodule.cpp https://commits.kde.org/kdeclarative/84a370ce2c3ac48be9e8745a93cd347bba463323
Git commit 94b91f723a23d06cc62800b264d021e81cb16432 by Kai Uwe Broulik. Committed on 15/01/2018 at 09:32. Pushed by broulik into branch 'master'. [ConfigModel] Set QML context on ConfigModule This will have the ConfigModule use the same engine as we do, ensuring we use the correct QtQuick Controls style. Differential Revision: https://phabricator.kde.org/D9785 M +6 -0 src/plasmaquick/configmodel.cpp https://commits.kde.org/plasma-framework/94b91f723a23d06cc62800b264d021e81cb16432
@Anton: Thanks for your offer! While this bug sounded trivial, it required some extensive knowledge on how Plasma creates the QML and a bit of gut feeling about what went wrong here. See the two commits I had to made, they look trivial but finding out what happened was more challenging. Feel free to roam in the bugtracker, though, and see if you find anything else that suits you :) Also check out https://community.kde.org/Guidelines_and_HOWTOs
*** Bug 389477 has been marked as a duplicate of this bug. ***
*** Bug 390070 has been marked as a duplicate of this bug. ***
*** Bug 390305 has been marked as a duplicate of this bug. ***
*** Bug 390379 has been marked as a duplicate of this bug. ***
Apparently this returned in 5.14: https://bugs.kde.org/show_bug.cgi?id=398599