Bug 388766 - Looks ugly with dark themes
Summary: Looks ugly with dark themes
Status: RESOLVED FIXED
Alias: None
Product: plasma-pa
Classification: Plasma
Component: kcm (show other bugs)
Version: 5.11.5
Platform: Other Linux
: NOR normal
Target Milestone: ---
Assignee: David Rosca
URL:
Keywords:
: 389477 390070 390305 390379 (view as bug list)
Depends on:
Blocks:
 
Reported: 2018-01-10 08:41 UTC by varlesh
Modified: 2018-09-14 17:46 UTC (History)
8 users (show)

See Also:
Latest Commit:
Version Fixed In:


Attachments
plasma-pa with Breeze Dark (271.03 KB, image/png)
2018-01-10 08:41 UTC, varlesh
Details

Note You need to log in before you can comment on or make changes to this bug.
Description varlesh 2018-01-10 08:41:11 UTC
Created attachment 109779 [details]
plasma-pa with Breeze Dark

plasma-pa really looks ugly with dark theme on settings window.

ISSUES:
- Checkbox used from plasma theme. Why not used Qt checkbox from theme engine?
- Menuitem style hardcoded and impossible readable with dark theme.

STEPS FOR REPRODUCE:
- Set Breeze Dark style on systemsettings

- Open plasma-pa settings window, set tab Volume-Additional-Profile and tap on menuitem.

Preview attached.

More info here:
https://github.com/PapirusDevelopmentTeam/adapta-kde/issues/34
https://github.com/PapirusDevelopmentTeam/adapta-kde/issues/26

KDE Neon User Edition
Plasma 5.11.5
KDE Frameworks 5.41
Qt 5.9.3
Comment 1 Anton Hristov 2018-01-13 20:45:35 UTC
Hi,

I am a long-time KDE user who wants to get involved in the development and solve this bug. Would this be a good 'first-bug' to start with? Can someone please provide a bit more information on what needs to be done?
Comment 3 Kai Uwe Broulik 2018-01-15 09:32:12 UTC
Git commit 84a370ce2c3ac48be9e8745a93cd347bba463323 by Kai Uwe Broulik.
Committed on 15/01/2018 at 09:31.
Pushed by broulik into branch 'master'.

[ConfigModule] Re-use QML context and engine if any

In case the ConfigModule is created within a QML context, re-use it and its engine instead of creating a shared QML object that might use a different engine.

Differential Revision: https://phabricator.kde.org/D9784

M  +16   -2    src/quickaddons/configmodule.cpp

https://commits.kde.org/kdeclarative/84a370ce2c3ac48be9e8745a93cd347bba463323
Comment 4 Kai Uwe Broulik 2018-01-15 09:33:09 UTC
Git commit 94b91f723a23d06cc62800b264d021e81cb16432 by Kai Uwe Broulik.
Committed on 15/01/2018 at 09:32.
Pushed by broulik into branch 'master'.

[ConfigModel] Set QML context on ConfigModule

This will have the ConfigModule use the same engine as we do, ensuring we use the correct QtQuick Controls style.

Differential Revision: https://phabricator.kde.org/D9785

M  +6    -0    src/plasmaquick/configmodel.cpp

https://commits.kde.org/plasma-framework/94b91f723a23d06cc62800b264d021e81cb16432
Comment 5 Kai Uwe Broulik 2018-01-15 09:35:22 UTC
@Anton: Thanks for your offer! While this bug sounded trivial, it required some extensive knowledge on how Plasma creates the QML and a bit of gut feeling about what went wrong here. See the two commits I had to made, they look trivial but finding out what happened was more challenging.

Feel free to roam in the bugtracker, though, and see if you find anything else that suits you :) Also check out https://community.kde.org/Guidelines_and_HOWTOs
Comment 6 Kai Uwe Broulik 2018-02-05 16:06:30 UTC
*** Bug 389477 has been marked as a duplicate of this bug. ***
Comment 7 David Rosca 2018-02-08 12:58:45 UTC
*** Bug 390070 has been marked as a duplicate of this bug. ***
Comment 8 David Rosca 2018-02-12 07:56:19 UTC
*** Bug 390305 has been marked as a duplicate of this bug. ***
Comment 9 David Rosca 2018-02-13 15:33:22 UTC
*** Bug 390379 has been marked as a duplicate of this bug. ***
Comment 10 Nate Graham 2018-09-14 17:46:29 UTC
Apparently this returned in 5.14: https://bugs.kde.org/show_bug.cgi?id=398599