Bug 388751 - Show installed backends on Settings page even when no repos are defined, because you need to use their hamburger menu button to define repos
Summary: Show installed backends on Settings page even when no repos are defined, beca...
Status: RESOLVED FIXED
Alias: None
Product: Discover
Classification: Applications
Component: Flatpak Backend (show other bugs)
Version: unspecified
Platform: Other Linux
: NOR major
Target Milestone: ---
Assignee: Aleix Pol
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2018-01-09 19:41 UTC by Fabian Vogt
Modified: 2018-01-12 17:19 UTC (History)
2 users (show)

See Also:
Latest Commit:
Version Fixed In:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Fabian Vogt 2018-01-09 19:41:35 UTC
In the settings page, there are no Flatpak entries anymore. The "Add Flathub" action is missing as well.
flatpak is installed and a previous discover version shows flatpak just fine.
Comment 1 Nate Graham 2018-01-09 20:50:26 UTC
From git master, everything works fine for me as long as the Flatpak backend is actually installed (it's not installed by default in Ubuntu-based distros, don't know about OpenSUSE). The "Add Flathub" button only appears when the Flatpak backend is installed, but doesn't have any repos configured.

Can you confirm that you have the Flatpak backend installed?
Comment 2 Fabian Vogt 2018-01-09 20:52:48 UTC
gdb says that flatpak-backend.so is loaded.
I can singlestep through the constructor and it registers the source successfully.
Comment 3 Nate Graham 2018-01-09 21:11:45 UTC
Thanks. And this is with Discover compiled from git master?
Comment 4 Fabian Vogt 2018-01-09 21:21:08 UTC
(In reply to Nate Graham from comment #3)
> Thanks. And this is with Discover compiled from git master?

Yes: 2d9fb83a216d83e68aa0859344ee05fcc3d6fe14.

I have the impression that flatpak is just not shown anywhere as I have no sources defined. This makes adding an initial source impossible.
Comment 5 Nate Graham 2018-01-09 21:25:52 UTC
When I did this a few days ago, there was definitely an "Add Flathub" button on the toolbar on the top of the window. If you don't see that, it's probably another bug.

I think I see what's happening here though: without any pre-existing Flatpak repos configured, as of https://cgit.kde.org/discover.git/commit/?id=c8d5c23de57ca653d4442f8369b72251410e028b, the entry for Flatpak never appears, and thus the hamburger menu that lets you add repos is never visible.
Comment 6 Aleix Pol 2018-01-12 17:19:03 UTC
Git commit 7879a5b54373480158741dcd0b66d2d135db26e4 by Aleix Pol.
Committed on 12/01/2018 at 16:43.
Pushed by apol into branch 'master'.

List snap as a source too

M  +2    -1    discover/qml/AddSourceDialog.qml
M  +1    -1    discover/qml/SourcesPage.qml
M  +2    -0    libdiscover/backends/SnapBackend/SnapBackend.cpp

https://commits.kde.org/discover/7879a5b54373480158741dcd0b66d2d135db26e4
Comment 7 Aleix Pol 2018-01-12 17:19:04 UTC
Git commit 10fab95e35707df1f65883cdf08bc01b3e06f97e by Aleix Pol.
Committed on 12/01/2018 at 16:36.
Pushed by apol into branch 'master'.

List backends without sources in the Sources page

M  +92   -77   discover/qml/SourcesPage.qml
M  +2    -2    libdiscover/ActionsModel.cpp
M  +5    -5    libdiscover/ActionsModel.h
M  +1    -0    libdiscover/CMakeLists.txt
M  +3    -6    libdiscover/backends/DummyBackend/DummySourcesBackend.cpp
M  +0    -1    libdiscover/backends/DummyBackend/DummySourcesBackend.h
M  +0    -1    libdiscover/backends/FlatpakBackend/FlatpakSourcesBackend.cpp
M  +0    -1    libdiscover/backends/FlatpakBackend/FlatpakSourcesBackend.h
M  +0    -7    libdiscover/backends/PackageKitBackend/PackageKitSourcesBackend.cpp
M  +0    -1    libdiscover/backends/PackageKitBackend/PackageKitSourcesBackend.h
M  +1    -0    libdiscover/resources/AbstractResourcesBackend.h
M  +1    -4    libdiscover/resources/AbstractSourcesBackend.h
M  +48   -38   libdiscover/resources/SourcesModel.cpp
M  +9    -16   libdiscover/resources/SourcesModel.h

https://commits.kde.org/discover/10fab95e35707df1f65883cdf08bc01b3e06f97e