Bug 388745 - Scrolling beyond boundaries with PgUp/PgDn causes artifacts
Summary: Scrolling beyond boundaries with PgUp/PgDn causes artifacts
Status: RESOLVED FIXED
Alias: None
Product: Discover
Classification: Applications
Component: discover (show other bugs)
Version: unspecified
Platform: Other Linux
: NOR normal
Target Milestone: ---
Assignee: Aleix Pol
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2018-01-09 19:05 UTC by Fabian Vogt
Modified: 2018-01-10 19:25 UTC (History)
1 user (show)

See Also:
Latest Commit:
Version Fixed In:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Fabian Vogt 2018-01-09 19:05:24 UTC
When pressing PgUp while at the top of a page or PgDn at the bottom, the page vanishes. First press causes 50% to disappear, the second press 100%. The third press restores the page again.
Comment 1 Nate Graham 2018-01-09 20:41:49 UTC
Whoa! Can confirm with git master. Really weird behavior.
Comment 2 Aleix Pol 2018-01-10 02:44:22 UTC
Git commit f0dc351a2605b8e5695dd1f5c4a40aef6664881e by Aleix Pol.
Committed on 10/01/2018 at 02:39.
Pushed by apol into branch 'master'.

Make the sources page header a page header rather than a list header

M  +49   -51   discover/qml/SourcesPage.qml

https://commits.kde.org/discover/f0dc351a2605b8e5695dd1f5c4a40aef6664881e
Comment 3 Aleix Pol 2018-01-10 02:44:22 UTC
Git commit 17c61127db1d6c60e5269e62d7d20cf77a95ef36 by Aleix Pol.
Committed on 10/01/2018 at 02:40.
Pushed by apol into branch 'master'.

Don't scroll up if on top, don't scroll down if at the bottom

M  +6    -0    discover/qml/DiscoverPage.qml

https://commits.kde.org/discover/17c61127db1d6c60e5269e62d7d20cf77a95ef36
Comment 4 Fabian Vogt 2018-01-10 08:30:18 UTC
Doesn't work when the scroll position is not aligned to the end/beginning or a multiple of the page height.

It looks like contentY must not ever go outside of bounds as returnToBounds doesn't have the desired effect.
Comment 5 Aleix Pol 2018-01-10 17:49:57 UTC
Git commit 204467d49e83c53158e185e73fe6c44c45bd9c43 by Aleix Pol.
Committed on 10/01/2018 at 17:45.
Pushed by apol into branch 'master'.

Add some extra checks to improve the keyboard scrolling

M  +10   -4    discover/qml/DiscoverPage.qml

https://commits.kde.org/discover/204467d49e83c53158e185e73fe6c44c45bd9c43
Comment 6 Fabian Vogt 2018-01-10 19:25:26 UTC
Git commit 124dd510d5a42f6f98f8134b5ddffd930547ec1e by Fabian Vogt.
Committed on 10/01/2018 at 19:25.
Pushed by fvogt into branch 'master'.

Fix scrolling with keyboard

Replace the previous guards with a single statement.

M  +3    -16   discover/qml/DiscoverPage.qml

https://commits.kde.org/discover/124dd510d5a42f6f98f8134b5ddffd930547ec1e