Bug 388717 - Design Update Page
Summary: Design Update Page
Status: RESOLVED FIXED
Alias: None
Product: Discover
Classification: Applications
Component: discover (other bugs)
Version First Reported In: unspecified
Platform: Other Linux
: NOR normal
Target Milestone: ---
Assignee: Aleix Pol
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2018-01-09 10:32 UTC by andreas
Modified: 2018-01-10 08:53 UTC (History)
1 user (show)

See Also:
Latest Commit:
Version Fixed/Implemented In:
Sentry Crash Report:


Attachments
update page (227.30 KB, image/png)
2018-01-09 10:32 UTC, andreas
Details

Note You need to log in before you can comment on or make changes to this bug.
Description andreas 2018-01-09 10:32:45 UTC
Created attachment 109747 [details]
update page

the update information look a bit strange cause it didn't follow any other style in discover

buttons are ordinary right align (more informations) the ... isn't correct cause ... mean an dialog will open

I would suggest to use the font style from description (detail page) instead of bold for reason, updates, change log and remove the frame cause nowhere else a frame was used.
Comment 1 Nate Graham 2018-01-09 14:06:20 UTC
Not a bad idea.
Comment 2 Aleix Pol 2018-01-10 02:35:56 UTC
It's not something we can pass on easily, as it's html that we are rendering instead of QML components. Will integrate the rest of the feedback.
Comment 3 Aleix Pol 2018-01-10 02:37:17 UTC
Git commit ca1ac7cfd338378480327d38156cbff858f7328b by Aleix Pol.
Committed on 10/01/2018 at 02:32.
Pushed by apol into branch 'master'.

Improve UpdatePage resource delegate

Align the "more info" button to the right.
Improve placement of the changelog frame to accommodate changelogs with
multiple lines

M  +8    -3    discover/qml/UpdatesPage.qml

https://commits.kde.org/discover/ca1ac7cfd338378480327d38156cbff858f7328b
Comment 4 andreas 2018-01-10 08:53:09 UTC
can you parse the "headers"