Bug 388688 - appdata screenshots broken
Summary: appdata screenshots broken
Status: RESOLVED FIXED
Alias: None
Product: KBibTeX
Classification: Applications
Component: General (other bugs)
Version First Reported In: git (master)
Platform: Other Linux
: NOR normal
Target Milestone: ---
Assignee: Thomas Fischer
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2018-01-08 17:02 UTC by Harald Sitter
Modified: 2018-01-08 19:46 UTC (History)
0 users

See Also:
Latest Commit:
Version Fixed/Implemented In:
Sentry Crash Report:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Harald Sitter 2018-01-08 17:02:55 UTC
Your appdata points to `https://userbase.kde.org/images.userbase/7/7f/20150602-kbibtex-kf5.png` as screenshot.

- This image comes out of the wiki. Never ever use wiki images as appstream screenshots. Our wikis have ddos protection which can trigger off of automated crawling as needs to be done with appstream data.
- As the image comes from mediawiki it actually isn't valid png at all as wiki sends html embedding the image which renders the url broken for all intents and purposes


```
curl https://userbase.kde.org/images.userbase/7/7f/20150602-kbibtex-kf5.png
<html>
<head>
<META NAME="robots" CONTENT="noindex,nofollow">
<script src="/_Incapsula_Resource?SWJIYLWA=2977d8d74f63d7f8fedbea018b7a1d05">
</script>
<script>
(function() { 
var z="";var b="7472797B766172207868723B76617220743D6E6577204461746528292E67657454696D6528293B766172207374617475733D227374617274223B7661722074696D696E673D6E65772041727261792833293B77696E646F772E6F6E756E6C6F61643D66756E6374696F6E28297B74696D696E675B325D3D22723A222B286E6577204461746528292E67657454696D6528292D74293B646F63756D656E742E637265617465456C656D656E742822696D6722292E7372633D222F5F496E63617073756C615F5265736F757263653F4553324C555243543D363726743D373826643D222B656E636F6465555249436F6D706F6E656E74287374617475732B222028222B74696D696E672E6A6F696E28292B222922297D3B69662877696E646F772E584D4C4874747052657175657374297B7868723D6E657720584D4C48747470526571756573747D656C73657B7868723D6E657720416374697665584F626A65637428224D6963726F736F66742E584D4C4854545022297D7868722E6F6E726561647973746174656368616E67653D66756E6374696F6E28297B737769746368287868722E72656164795374617465297B6361736520303A7374617475733D6E6577204461746528292E67657454696D6528292D742B223A2072657175657374206E6F7420696E697469616C697A656420223B627265616B3B6361736520313A7374617475733D6E6577204461746528292E67657454696D6528292D742B223A2073657276657220636F6E6E656374696F6E2065737461626C6973686564223B627265616B3B6361736520323A7374617475733D6E6577204461746528292E67657454696D6528292D742B223A2072657175657374207265636569766564223B627265616B3B6361736520333A7374617475733D6E6577204461746528292E67657454696D6528292D742B223A2070726F63657373696E672072657175657374223B627265616B3B6361736520343A7374617475733D22636F6D706C657465223B74696D696E675B315D3D22633A222B286E6577204461746528292E67657454696D6528292D74293B6966287868722E7374617475733D3D323030297B706172656E742E6C6F636174696F6E2E72656C6F616428297D627265616B7D7D3B74696D696E675B305D3D22733A222B286E6577204461746528292E67657454696D6528292D74293B7868722E6F70656E2822474554222C222F5F496E63617073756C615F5265736F757263653F535748414E45444C3D373235303135303837353833303430373534312C343432303332323236333133373732313931392C31313838353635323638383538393838333534302C32313930343932222C66616C7365293B7868722E73656E64286E756C6C297D63617463682863297B7374617475732B3D6E6577204461746528292E67657454696D6528292D742B2220696E6361705F6578633A20222B633B646F63756D656E742E637265617465456C656D656E742822696D6722292E7372633D222F5F496E63617073756C615F5265736F757263653F4553324C555243543D363726743D373826643D222B656E636F6465555249436F6D706F6E656E74287374617475732B222028222B74696D696E672E6A6F696E28292B222922297D3B";for (var i=0;i<b.length;i+=2){z=z+parseInt(b.substring(i, i+2), 16)+",";}z = z.substring(0,z.length-1); eval(eval('String.fromCharCode('+z+')'));})();
</script></head>
<body>
<iframe style="display:none;visibility:hidden;" src="//content.incapsula.com/jsTest.html" id="gaIframe"></iframe>
</body></html>% 
```

Please fix by ideally switch to the KDE product screenshot hosting @ https://phabricator.kde.org/source/websites-product-screenshots/browse/master/README.md
Comment 1 Thomas Fischer 2018-01-08 19:38:42 UTC
Ok, going to fix ...
Comment 2 Thomas Fischer 2018-01-08 19:43:56 UTC
Git commit 59a77102b8acd140b2833af153e99f56474926f6 by Thomas Fischer.
Committed on 08/01/2018 at 19:41.
Pushed by thomasfischer into branch 'master'.

Screenshot URL points to KDE's CDN

The screenshot for KBibTeX as links in the AppData file has been
replaced to point to KDE's content distribution network where
screenshots are supposed to reside (instead of the UserBase Wiki).

M  +1    -1    src/program/org.kde.kbibtex.appdata.xml

https://commits.kde.org/kbibtex/59a77102b8acd140b2833af153e99f56474926f6
Comment 3 Thomas Fischer 2018-01-08 19:46:03 UTC
Git commit 6ad6455751a6201048f94430e6ed446d21a18a5b by Thomas Fischer.
Committed on 08/01/2018 at 19:45.
Pushed by thomasfischer into branch 'kbibtex/0.7'.

Screenshot URL points to KDE's CDN

The screenshot for KBibTeX as linked in the AppData file has been
replaced to point to KDE's content distribution network where
screenshots are supposed to reside (instead of the UserBase Wiki).

M  +1    -1    kbibtex.appdata.xml

https://commits.kde.org/kbibtex/6ad6455751a6201048f94430e6ed446d21a18a5b