Bug 388680 - Untranslatable " (auto-detected)" in camera name
Summary: Untranslatable " (auto-detected)" in camera name
Status: RESOLVED FIXED
Alias: None
Product: digikam
Classification: Applications
Component: Usability-i18n (show other bugs)
Version: 7.0.0
Platform: Compiled Sources Linux
: NOR normal
Target Milestone: ---
Assignee: Digikam Developers
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2018-01-08 13:40 UTC by Alexander Potashev
Modified: 2020-08-18 20:22 UTC (History)
3 users (show)

See Also:
Latest Commit:
Version Fixed In: 7.1.0
Sentry Crash Report:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Alexander Potashev 2018-01-08 13:40:01 UTC
The camera name suffix " (auto-detected)" is not translatable. It is visible in UI in the Import->Cameras menu.

utilities/importui/views/cameranamehelper.cpp:static const QString STR_AUTO_DETECTED(QLatin1String("auto-detected"));
Comment 1 caulier.gilles 2018-01-08 17:55:20 UTC
I'm not sure but this string from utilities/importui/views/cameranamehelper.cpp is used in a regular expression, and i think it cannot be translated as well.

Gilles Caulier
Comment 2 Maik Qualmann 2018-01-08 17:57:13 UTC
Yes, and the string is used in an IF condition.

Maik
Comment 3 Alexander Potashev 2019-02-22 23:44:48 UTC
This string has moved into core/utilities/import/views/cameranamehelper.cpp, but is still untranslatable.
Comment 4 caulier.gilles 2020-08-04 08:13:52 UTC
digiKam 7.0.0 stable release is now published:

https://www.digikam.org/news/2020-07-19-7.0.0_release_announcement/

We need a fresh feedback on this file using this version.

Best Regards

Gilles Caulier
Comment 5 Alexander Potashev 2020-08-15 21:36:30 UTC
The string is still hard-coded in English: https://invent.kde.org/graphics/digikam/-/blob/master/core/utilities/import/views/cameranamehelper.cpp#L32
Comment 6 caulier.gilles 2020-08-18 09:15:46 UTC
Maik,

To fix the problem i suppose that regex string "auto-detected" and the menu string declarations must be separated to make last one translatable.

Gilles
Comment 7 Maik Qualmann 2020-08-18 20:22:32 UTC
Git commit dc8798e1e583ba58600237988cd5928aa4292de5 by Maik Qualmann.
Committed on 18/08/2020 at 20:21.
Pushed by mqualmann into branch 'master'.

it should be safe to translate this string
FIXED-IN: 7.1.0

M  +2    -1    NEWS
M  +5    -1    core/utilities/import/views/cameranamehelper.cpp

https://invent.kde.org/graphics/digikam/commit/dc8798e1e583ba58600237988cd5928aa4292de5