Bug 388678 - Newly added or changed actions are missing in menu
Summary: Newly added or changed actions are missing in menu
Status: RESOLVED FIXED
Alias: None
Product: krusader
Classification: Applications
Component: general (show other bugs)
Version: Git
Platform: unspecified Linux
: NOR normal
Target Milestone: ---
Assignee: Nikita Melnichenko
URL:
Keywords: reproducible, triaged
Depends on:
Blocks:
 
Reported: 2018-01-08 13:21 UTC by Kevin Kofler
Modified: 2022-06-09 04:07 UTC (History)
4 users (show)

See Also:
Latest Commit:
Version Fixed In:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Kevin Kofler 2018-01-08 13:21:26 UTC
Note: I am seeing this with 2.5.0, but looking at the source code, the issue appears to still exist in 2.6.0 and master.

The Edit / Rename and Tools / Open terminal here actions are missing in the main menu, because https://cgit.kde.org/krusader.git/tree/krusader/krusaderui.rc still references F9_Rename and F2_Term, which should probably be F2_Rename and F9_Term now that the keys were swapped.
Comment 1 Toni Asensi Esteve 2018-01-08 21:03:07 UTC
Hi!

> because
> https://cgit.kde.org/krusader.git/tree/krusader/krusaderui.rc still references
> F9_Rename and F2_Term, which should probably be F2_Rename and F9_Term now that
> the keys were swapped.

I tried to rename it to F2_Rename and F9_Term, I compiled and executed Krusader, but I saw no change (using Kubuntu 17.10).
Kevin, if you rename the texts to F2_Rename and F9_Term, compile and execute Krusader... does it work as you expected?

Thanks
Comment 2 Nikita Melnichenko 2018-02-15 07:21:24 UTC
Kevin, has Toni's suggestion fixed the issue? Please also share your ~/.local/share/kxmlgui5/krusader/krusaderui.rc
Comment 3 Christoph Feck 2018-03-01 01:19:05 UTC
If you can provide the information requested in comment #2, please add it.
Comment 4 Christoph Feck 2018-03-29 14:06:28 UTC
To further investigate this issue, KDE developers need the information requested in comment #2. If you can provide it, or need help with finding that information, please add a comment.
Comment 5 Christoph Feck 2018-04-26 21:24:47 UTC
No response; changing status. If you have new information, please add a comment.
Comment 6 Nikita Melnichenko 2018-04-30 06:22:52 UTC
I'd like to reopen even though the original author doesn't respond.

Toni's change https://phabricator.kde.org/D12524 addresses the issue for new installs, however it's still the problem for existing installs, in particular the file ~/.local/share/kxmlgui5/krusader/krusaderui.rc is going to contain old actions in menu even though a fixed version of krusader exe is running. This is because the menu is copied from shared location to user home dir at the first run and never refreshes automatically. It's a fundamental issue with menu actions and user actions.

In the same time, the workaround is simple - just remove the file in user dir.
Comment 7 Nikita Melnichenko 2021-12-22 21:06:22 UTC
Ah, this bites us again with new options regarding undoing closed tabs in master branch. When we release v2.8, user simply won't see new options. :(

Workaround of removing the ~/.local/share/kxmlgui5/krusader/krusaderui.rc file is far from great, as user will loose shortcut overrides and toolbars. And many users won't even think of refreshing the rc file...

To solve this and keep configurability of the menu we need to add "disabled" menu actions in the rc file. Then, if we have an action that is not mentioned in the rc (enabled or disabled), add it there during startup.
Comment 8 Bug Janitor Service 2021-12-23 04:32:00 UTC
A possibly relevant merge request was started @ https://invent.kde.org/utilities/krusader/-/merge_requests/78
Comment 9 Nikita Melnichenko 2022-06-09 04:07:05 UTC
Git commit 9c805860b069a2048ddd0234b7cbe5eea987b65b by Nikita Melnichenko.
Committed on 09/06/2022 at 04:04.
Pushed by melnichenko into branch 'master'.

Fixed krusaderui.rc update issue when user opens a new build

Put a note for devs to not forget updating the version.
In addition, cleaned up old comments in the file.

FIXED: [ 388678 ] Newly added or changed actions are missing in menu

Discussion: https://invent.kde.org/utilities/krusader/-/merge_requests/78

M  +4    -24   krusader/krusaderui.rc

https://invent.kde.org/utilities/krusader/commit/9c805860b069a2048ddd0234b7cbe5eea987b65b