Bug 388565 - Text typed after default text is bold and underlined
Summary: Text typed after default text is bold and underlined
Status: RESOLVED FIXED
Alias: None
Product: krita
Classification: Applications
Component: Tool/Text (show other bugs)
Version: 4.0 pre-alpha
Platform: Microsoft Windows Microsoft Windows
: NOR minor
Target Milestone: ---
Assignee: Krita Bugs
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2018-01-05 13:43 UTC by Alex
Modified: 2018-01-06 17:47 UTC (History)
2 users (show)

See Also:
Latest Commit:
Version Fixed In:
Sentry Crash Report:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Alex 2018-01-05 13:43:14 UTC
To replicate:
- create empty image
- use text tool to add text
- put cursor at the end of text and type anything
- save to see
It's minor but reporting as it may have influence on other things.
Comment 1 Halla Rempt 2018-01-05 13:45:06 UTC
Is this with the new text tool, i.e., did you build from master? Or with the old text tool, i.e. with the last development build from download.kde.org?
Comment 2 Alex 2018-01-05 13:53:51 UTC
It's new one.
Krita version: 4.0 alpha, git aeb04cc from nightly build archive for Windows.
Comment 3 Nicholas LaPointe 2018-01-05 14:54:54 UTC
I reproduced this using 870fc2b91395be171b554a76d03b6adda8547356 , with the caveats that the text needs to be typed and that it's not actually bold (the letters are stacked instead).

Typing:
>  Hello World!

into the rich text editor after "Lorem ipsum dolor sit amet, consectetur adipiscing elit." gave the SVG:
> <text style="">
>     <tspan>Lorem ipsum dolor sit amet, consectetur adipiscing elit.<tspan style="letter-spacing:-10; word-spacing:0; kerning:normal; font-family:Noto Sans; font-size:10pt; font-weight:400; font-style:normal; font-stretch:0; text-decoration:underline"> Hello World!</tspan>
>     </tspan>
> </text>

Saving it again and then closing and going back to the editor gave:
> <text style="">
>     <tspan>Lorem ipsum dolor sit amet, consectetur adipiscing elit.<tspan style="letter-spacing:0; word-spacing:0; kerning:none; font-stretch:0; text-decoration:overline"> Hello World!</tspan>
>     </tspan>
> </text>

Pasting into the rich text editor instead of typing worked as expected:
> <text style="">
>     <tspan>Lorem ipsum dolor sit amet, consectetur adipiscing elit. Hello World!</tspan>
> </text>
Comment 4 Nicholas LaPointe 2018-01-05 15:40:45 UTC
(In reply to Nicholas LaPointe from comment #3)
> I reproduced this using 870fc2b91395be171b554a76d03b6adda8547356 , with the
> caveats that the text needs to be typed and that it's not actually bold (the
> letters are stacked instead).
> ...
> Pasting into the rich text editor instead of typing worked as expected:
Whoops, pasting only works correctly if you paste the entire line. Only pasting " Hello World!" is the same as typing it.
Comment 5 wolthera 2018-01-06 17:47:23 UTC
Git commit ac60ebc7bd85137a0994dfba30ee42440d29b948 by Wolthera van Hövell tot Westerflier.
Committed on 06/01/2018 at 17:47.
Pushed by woltherav into branch 'master'.

If this still happens, reopen the bug.

I also made sure that if we're ever adding spell check it won't
add those underlines too.

M  +17   -11   libs/flake/text/KoSvgTextShapeMarkupConverter.cpp

https://commits.kde.org/krita/ac60ebc7bd85137a0994dfba30ee42440d29b948