Commit https://cgit.kde.org/kdepim-runtime.git/commit/resources /ews/ewsresource.cpp?id=7c74258355cd91106d7563142177dd7f17801256 broke authentication for servers always requiring a domain delimiter, even with an empty domain. See https://github.com/KrissN/akonadi-ews/pull/39
Git commit 86302684a48fb4340facd5f773ab14556bc82219 by Stefan Brüns. Committed on 03/05/2018 at 22:38. Pushed by bruns into branch 'master'. Always add domain delimiter if "Domain" checkbox is selected Summary: EwsConfigDialog::fullUsername() always adds the domain delimiter when the "Domain" checkbox is set, even if the actual domain name is empty, while the login procedure in EwsResource::passwordRequestFinished(...) only adds a domain delimiter if the domain is non-empty. Make sure login in the config dialog and during normal operation is equivalent. Not sending an (empty) domain causes login failures for some servers, while sending it seems to be unproblematic, and can be forced off by unselecting the checkbox. This fixes a regression caused by commit 7c74258355cd ("EWS: Refactor server connection and password retrieval"), which changed the check for sending the domain from mSettings->hasDomain() to mSettings->domain().isEmpty(). Related: bug 390798 Test Plan: Check the login from the config-dialog, once //with//, once //without// checking "Domain" Try to sync the resource Reviewers: dvratil, nowicki Reviewed By: dvratil Subscribers: #kde_pim Tags: #kde_pim Differential Revision: https://phabricator.kde.org/D12474 https://commits.kde.org/kdepim-runtime/86302684a48fb4340facd5f773ab14556bc82219
Git commit a20701f5837e067496ef91954940c49eb9e15beb by Stefan Brüns. Committed on 03/05/2018 at 22:38. Pushed by bruns into branch 'master'. Always add domain delimiter if "Domain" checkbox is selected Summary: EwsConfigDialog::fullUsername() always adds the domain delimiter when the "Domain" checkbox is set, even if the actual domain name is empty, while the login procedure in EwsResource::passwordRequestFinished(...) only adds a domain delimiter if the domain is non-empty. Make sure login in the config dialog and during normal operation is equivalent. Not sending an (empty) domain causes login failures for some servers, while sending it seems to be unproblematic, and can be forced off by unselecting the checkbox. This fixes a regression caused by commit 7c74258355cd ("EWS: Refactor server connection and password retrieval"), which changed the check for sending the domain from mSettings->hasDomain() to mSettings->domain().isEmpty(). Related: bug 390798 Test Plan: Check the login from the config-dialog, once //with//, once //without// checking "Domain" Try to sync the resource Reviewers: dvratil, nowicki Reviewed By: dvratil Subscribers: #kde_pim Tags: #kde_pim Differential Revision: https://phabricator.kde.org/D12474 M +1 -1 resources/ews/ewsresource.cpp https://commits.kde.org/kdepim-runtime/a20701f5837e067496ef91954940c49eb9e15beb