Bug 388433 - Remove Warning Message When Changing Fonts
Summary: Remove Warning Message When Changing Fonts
Alias: None
Product: systemsettings
Classification: Applications
Component: kcm_fonts (show other bugs)
Version: unspecified
Platform: Other Linux
: NOR wishlist
Target Milestone: ---
Assignee: Unassigned bugs mailing-list
Depends on:
Reported: 2018-01-01 19:27 UTC by Andres Betts
Modified: 2019-07-26 14:55 UTC (History)
6 users (show)

See Also:
Latest Commit:
Version Fixed In:


Note You need to log in before you can comment on or make changes to this bug.
Description Andres Betts 2018-01-01 19:27:29 UTC
Whenever the user changes fonts using system settings, the apply button will trigger a popup menu, where you have to click OK, to understand that effects will take only on new windows and may not be apparent immediately.

This can be removed.

Instead, it is best to leave a small message on the KCM itself that says something similar and avoid having the user click another OK button. It may give the impression that something went wrong.

Solution: Add message in KCM that says

"These changes will take effect on new windows."
Comment 1 Nate Graham 2018-01-02 16:53:27 UTC
Yeah,we should use an inline KMessageWidget for this instead of an intrusive pop-up window.
Comment 2 Kai Uwe Broulik 2018-01-08 09:47:57 UTC
Given this is being redone in QML, I wouldn't invest any effort in it right now but I agree. I did the same for appmenu settings where a message widget is used (obsolete now, but it was there :D)
Comment 3 Eike Hein 2018-04-04 09:21:10 UTC
*InlineMessage swoops in on a swinging rope*
Comment 4 Andres Betts 2018-04-04 14:03:10 UTC
Comment 5 Filip Fila 2019-03-22 21:58:08 UTC
We can revisit this now, right?
Comment 6 Nate Graham 2019-03-24 15:53:12 UTC
Yep! It's QML now and using InlineMessage should be pretty simple.
Comment 7 Filip Fila 2019-07-26 14:55:59 UTC
Git commit eae23d5d141b959a560b05a6a9403c1b0b188435 by Filip Fila.
Committed on 26/07/2019 at 14:55.
Pushed by filipf into branch 'master'.

[kcms/fonts] Replace warning message with inline message when applying changes

This patch gets rid of the popup message spawned when applying changes in the Fonts KCM and instead places the very same information in an inline message.

Test Plan: {F7097619}

Reviewers: #plasma, #vdg, ngraham, davidedmundson

Reviewed By: #plasma, #vdg, ngraham, davidedmundson

Subscribers: davidedmundson, broulik, plasma-devel

Tags: #plasma

Differential Revision: https://phabricator.kde.org/D22752

M  +3    -10   kcms/fonts/fonts.cpp
M  +1    -0    kcms/fonts/fonts.h
M  +194  -180  kcms/fonts/package/contents/ui/main.qml