Bug 388340 - Files get deleted if I rename them from the Application Menu's Search Box!
Summary: Files get deleted if I rename them from the Application Menu's Search Box!
Status: RESOLVED FIXED
Alias: None
Product: plasmashell
Classification: Plasma
Component: Application Menu (Kicker) widget (other bugs)
Version First Reported In: 5.11.4
Platform: Arch Linux Linux
: NOR critical
Target Milestone: 1.0
Assignee: Eike Hein
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2017-12-29 21:40 UTC by Xeno Idaltu
Modified: 2018-01-03 12:25 UTC (History)
2 users (show)

See Also:
Latest Commit:
Version Fixed/Implemented In:
Sentry Crash Report:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Xeno Idaltu 2017-12-29 21:40:27 UTC
If i search for cars.txt using the Application Menu and then Right Click it gives us the Edit Application option.

If I rename cars.txt to cars2017.txt the file is lost forever. It doesn't even send it to Trash Directory but automatically deletes it from the system!!
Comment 1 Eike Hein 2018-01-01 10:43:50 UTC
That sounds quite serious. Apologies for beign away over the holidays, we'll look into it soon.
Comment 2 David Edmundson 2018-01-02 12:38:31 UTC
you can recover your lost file from ~/.local/share/applications

but it's definitely a bug.
Comment 3 Eike Hein 2018-01-02 16:39:36 UTC
Git commit 16c97a1645ae5d5429e87a352e46e661373a64c1 by Eike Hein.
Committed on 02/01/2018 at 16:39.
Pushed by hein into branch 'Plasma/5.11'.

Don't show "Edit Application..." action for non-app services.

Summary:
When the code was refactored to show this action also for runner
matches, proper care wasn't taken to test for this, so the action
was shown for document matches as well. It's not safe to use for
docs currently (which should probably be fixed in
KPropertiesDialog) and at any rate isn't meant to be a generic
editing feature as per the action name.

Reviewers: #plasma, broulik, davidedmundson

Subscribers: plasma-devel

Tags: #plasma

Differential Revision: https://phabricator.kde.org/D9612

M  +4    -4    applets/kicker/plugin/actionlist.cpp
M  +10   -2    applets/kicker/plugin/runnermatchesmodel.cpp

https://commits.kde.org/plasma-desktop/16c97a1645ae5d5429e87a352e46e661373a64c1
Comment 4 Xeno Idaltu 2018-01-03 04:22:58 UTC
(In reply to Eike Hein from comment #1)
> That sounds quite serious. Apologies for beign away over the holidays, we'll
> look into it soon.

Thank you so much guys! I found my missing files. 

I think I lost more in the past while trying different KDE Distros since I use a 2HDD as storage, but at least now it will be fixed. =)
Comment 5 Eike Hein 2018-01-03 12:25:44 UTC
Yep, the fix will be in Plasma 5.11.5 and 5.12.

Thanks for your report. Bug reporting is really worth it, some things we just don't catch otherwise!