Bug 388339 - Crash when importing Pentax DNG file
Summary: Crash when importing Pentax DNG file
Status: RESOLVED FIXED
Alias: None
Product: digikam
Classification: Applications
Component: Metadata-Raw (show other bugs)
Version: 5.7.0
Platform: Microsoft Windows Microsoft Windows
: NOR crash
Target Milestone: ---
Assignee: Digikam Developers
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2017-12-29 21:28 UTC by Hombre
Modified: 2019-12-23 17:29 UTC (History)
3 users (show)

See Also:
Latest Commit:
Version Fixed In: 7.0.0
Sentry Crash Report:


Attachments
backtrace of the crash (12.04 KB, text/plain)
2017-12-29 21:28 UTC, Hombre
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Hombre 2017-12-29 21:28:00 UTC
Created attachment 109583 [details]
backtrace of the crash

During update of the database on opening digikam 5.7.0, it crash when with the attached BT. The last scanned file was IMGP0020.DNG (full path: "E:\Photos\PENTAX K10D\IMGP0020.DNG") that you'll find here : https://filebin.net/y2crloldk22f5gf3

As said in the bt, crash occurred on line 1273 which use 'lensInfo' from line 1272, while it already exist from line 1257, and it differentiate DNG from PEF makernotes there. So my guess is that line 1272 shouldn't be there at all.

After some search on existing bug list, none found with this reason. I hope to have looked correctly though.
Comment 1 Hombre 2017-12-29 21:32:08 UTC
Sorry, forgot to mention: line 1273 of pentaxmn.cpp, but I guess you guessed it yourself :/
Comment 2 caulier.gilles 2017-12-29 22:46:00 UTC
The crash appear in Exiv2 shared library. Please report this problem to Exiv2 project :

http://www.exiv2.org/

Gilles Caulier
Comment 3 Maik Qualmann 2017-12-29 22:48:56 UTC
The crash is reproducible with the exiv2 CLI tool.

Maik
Comment 4 caulier.gilles 2017-12-30 06:57:49 UTC
Hombre, 

This file is definitively an UPSTREAM one. Please report this problem to Exiv2 bugzilla. Nothing can be changed in digiKam source code. Thanks in advance.

Gilles Caulier
Comment 5 Simon 2017-12-30 10:00:52 UTC
Exiv2 now lives mainly on github and has two (?) new active devs. Please report any issues there (redmine/bugzilla on exiv2.org is still online, but not active):
https://github.com/Exiv2/exiv2/issues

I reproduced this on exiv2's master and took the liberty to already report it upstream: https://github.com/Exiv2/exiv2/issues/201
Comment 6 caulier.gilles 2017-12-30 10:09:41 UTC
Thanks Simon for the upstream task

Gilles
Comment 7 Hombre 2017-12-30 10:20:23 UTC
Thanks for the prompt reply, and yeah, I should have figured out to report it on the right project... Sorry for the lost time on this.
Comment 8 Hombre 2018-06-25 22:49:52 UTC
The issue has been fixed on January 13th in this commit https://github.com/Exiv2/exiv2/commit/b7d76da9d554a9dada7ca0a4e2d9cbc84c8b3847

However digiKam 5.9.0 still crash at the same location. I guess you still provide the unpatched exiv2 library.

I managed to build the last version of exiv2 (Release and Debug build), however digiKam still crash but not at the same location. I guess problem can arise due to version mismatch between the old include file and the new library?

Could you build and provide the last exiv2 library in your next Release please ? I just reopened the issue to put it on your radar, I'll let you close it again...
Comment 9 caulier.gilles 2018-06-26 03:43:33 UTC
The digiKam bundles (Linux, Windows, MacOS) use the official Exiv2 0.26 release which is the last one published.

The fix for your problem come from Exiv2 implementation. It have been fixed in January 2018. Exiv2 0.26 have been release in May 2017. Do you feel the problem ?

There is no maintenance release of Exiv2 since more than one year, and i refuse to use development code in a stable digiKam release.

Exiv2 project must plan small release more frequently. This is the base of open source project management.

So, no way. This file must be closed as UPSTREAM bug and the real problem reported to Exiv2 team...

Gilles Caulier
Comment 10 Hombre 2018-06-30 13:06:27 UTC
I just overlooked that there was so few release of exiv2. I'll just wait for the next DigiKam release then, which will include the last exiv2 library.

Bonne journée
Comment 11 caulier.gilles 2019-12-23 17:29:02 UTC
Not reproducible with digiKam 7.0.0-beta1.