Bug 388336 - It is possible to select shapes on a locked vector layer.
Summary: It is possible to select shapes on a locked vector layer.
Status: RESOLVED FIXED
Alias: None
Product: krita
Classification: Applications
Component: Layers/Vector (show other bugs)
Version: git master (please specify the git hash!)
Platform: Other Linux
: NOR normal
Target Milestone: ---
Assignee: Dmitry Kazarov
URL:
Keywords:
: 388926 (view as bug list)
Depends on:
Blocks:
 
Reported: 2017-12-29 18:50 UTC by wolthera
Modified: 2018-02-09 14:06 UTC (History)
3 users (show)

See Also:
Latest Commit: https://commits.kde.org/krita/76e0300e48c0c499586a17dcb4ba80b586067665
Version Fixed In:

Attachments
Add an attachment

Note You need to log in before you can comment on or make changes to this bug.
Description wolthera 2017-12-29 18:50:03 UTC 
It is also currently possible to add text shapes to a locked vector layer. These two things might be related.
Comment 1 wolthera 2018-01-13 20:59:28 UTC 
*** Bug 388926 has been marked as a duplicate of this bug. ***
Comment 2 mvowada 2018-01-15 11:02:22 UTC 
(Confirming)
Comment 3 Dmitry Kazakov 2018-02-09 11:21:25 UTC 
Well, it is also possible to select and move a shape on an invisible layer :)
Comment 4 Dmitry Kazakov 2018-02-09 14:06:14 UTC 
Git commit 76e0300e48c0c499586a17dcb4ba80b586067665 by Dmitry Kazakov.
Committed on 09/02/2018 at 14:05.
Pushed by dkazakov into branch 'master'.

Fix lockness of the shapes when the layer is locked/invisible

When the layer is locked, the shapes should be selectable, but
not editable. When the layer is invisible, the shapes should also
be invisible (thanks, cap!)

M  +1    -1    libs/flake/KoCanvasControllerWidgetViewport_p.cpp
M  +19   -5    libs/flake/KoSelection.cpp
M  +6    -2    libs/flake/KoSelection.h
M  +9    -8    libs/flake/KoShape.cpp
M  +2    -2    libs/flake/KoShape.h
M  +0    -8    libs/flake/KoShapeContainer.cpp
M  +0    -8    libs/flake/KoShapeContainer.h
M  +0    -8    libs/flake/KoShapeContainerModel.h
M  +4    -4    libs/flake/KoShapeManager.cpp
M  +1    -1    libs/flake/KoShapeSavingContext.cpp
M  +1    -1    libs/flake/KoShapeShadow.cpp
M  +2    -2    libs/flake/KoSnapProxy.cpp
M  +1    -1    libs/flake/KoToolManager.cpp
M  +1    -1    libs/flake/KoToolProxy.cpp
M  +0    -8    libs/flake/KoTosContainerModel.cpp
M  +0    -1    libs/flake/KoTosContainerModel.h
M  +2    -10   libs/flake/SimpleShapeContainerModel.h
M  +1    -1    libs/flake/resources/KoSvgSymbolCollectionResource.cpp
M  +1    -1    libs/flake/svg/KoShapePainter.cpp
M  +1    -1    libs/flake/svg/SvgStyleWriter.cpp
M  +0    -4    libs/flake/tests/MockShapes.h
M  +1    -1    libs/flake/tools/KoPathTool.cpp
M  +1    -1    libs/image/kis_base_node.h
M  +15   -0    libs/ui/flake/kis_shape_layer.cc
M  +4    -0    libs/ui/flake/kis_shape_layer.h
M  +0    -5    libs/ui/flake/kis_shape_selection_model.cpp
M  +0    -1    libs/ui/flake/kis_shape_selection_model.h
M  +1    -1    libs/widgets/KoToolBox.cpp
M  +0    -6    plugins/flake/textshape/ShrinkToFitShapeContainer.cpp
M  +0    -2    plugins/flake/textshape/ShrinkToFitShapeContainer.h
M  +0    -5    plugins/flake/textshape/textlayout/KoTextShapeContainerModel.cpp
M  +0    -2    plugins/flake/textshape/textlayout/KoTextShapeContainerModel.h
M  +1    -1    plugins/tools/defaulttool/connectionTool/ConnectionTool.cpp
M  +0    -24   plugins/tools/defaulttool/defaulttool/DefaultTool.cpp
M  +8    -6    plugins/tools/defaulttool/defaulttool/SelectionDecorator.cpp
M  +2    -2    plugins/tools/karbonplugins/tools/KarbonPatternTool.cpp

https://commits.kde.org/krita/76e0300e48c0c499586a17dcb4ba80b586067665