Bug 388320 - Selecting print layout does not stay selected.
Summary: Selecting print layout does not stay selected.
Status: RESOLVED FIXED
Alias: None
Product: digikam
Classification: Applications
Component: Plugin-Generic-PrintCreator (show other bugs)
Version: 5.9.0
Platform: Other Linux
: NOR normal
Target Milestone: ---
Assignee: Digikam Developers
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2017-12-29 11:09 UTC by IanMac
Modified: 2018-03-06 21:09 UTC (History)
2 users (show)

See Also:
Latest Commit:
Version Fixed In: 5.9.0


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description IanMac 2017-12-29 11:09:37 UTC
Using http://commits.kde.org/digikam/5e1856ef37cb9687a4100b256b70759684a8b804
on Windows 7

Tools -> Print Creator -> next 
Select a file to load,
Select one of my printers in this case Cute-PDF
select a layout  10 * 13.33 cm (4 photos)
select page settings , click OK  

Layout has reverted to the default second entry. However if you continue it actually uses the first entry 6 *8 cm 8 photos.
Comment 1 Maik Qualmann 2018-01-17 20:43:45 UTC
Git commit 3f12d87cb13dce3fb1a025d63beaff0faeddc766 by Maik Qualmann.
Committed on 17/01/2018 at 20:42.
Pushed by mqualmann into branch 'master'.

use the last selected layout / photo size after page setup
FIXED-IN: 5.9.0

M  +2    -1    NEWS
M  +4    -4    utilities/assistants/printcreator/wizard/advprintphotopage.cpp

https://commits.kde.org/digikam/3f12d87cb13dce3fb1a025d63beaff0faeddc766
Comment 2 rob 2018-03-01 13:40:57 UTC
I'm was getting the same problem as IanMac using version 5.8

Have updated to 5.9 beta, still get the same problem, can you advise?

Thanks,
Rob
Comment 3 rob 2018-03-01 16:44:40 UTC
On the Layout selection panel, if I select 10x15cm (3 photos) it will display there are 5 pages as I have selected 14 photos.

So I click next, to the caption settings, then next again to crop and rotate photos.

I then click back twice to go back to layout selection.

This time both the 10x15cm layout (which I had selected) is selected. But this time, the 6x9cm layout (1st option) is also selected. It also states that  there are 2 pages which is the correct number for the 6x9cm layout, rather than 5 pages for the layout had selected.
Comment 4 Maik Qualmann 2018-03-01 18:50:52 UTC
I can not reproduce the main problem from comment 0. Of course, if you switch from landscape to portrait in the page settings, the default layout is no longer available and the first one is selected. If you selec are e.g. (10x15 1 photo), this also remains selected because available in both orientations. Can you please test it again? The other thing with the back button and the double selection I can confirm and will be fixed.

Maik
Comment 5 Maik Qualmann 2018-03-01 19:22:14 UTC
Git commit 0e94d323ad074a37d636cb9e26df7f393e2e3ff4 by Maik Qualmann.
Committed on 01/03/2018 at 19:21.
Pushed by mqualmann into branch 'development/6.0.0'.

fix duplicate layout selection if use the back button
and corrects possible misalignment of cropped images

M  +5    -7    utilities/assistants/printcreator/wizard/advprintwizard.cpp

https://commits.kde.org/digikam/0e94d323ad074a37d636cb9e26df7f393e2e3ff4
Comment 6 Maik Qualmann 2018-03-01 19:25:25 UTC
Git commit c63b0c680076149adab27958dc50c7c5dee1032b by Maik Qualmann.
Committed on 01/03/2018 at 19:24.
Pushed by mqualmann into branch 'master'.

fix duplicate layout selection if use the back button
and corrects possible misalignment of cropped images

M  +5    -7    utilities/assistants/printcreator/wizard/advprintwizard.cpp

https://commits.kde.org/digikam/c63b0c680076149adab27958dc50c7c5dee1032b
Comment 7 rob 2018-03-01 19:39:02 UTC
Sorry, I misread the original bug report and comment 0. It sounded like the problem I had but now I'm thinking it maybe different. I didn't want to submit a new bug report for something that had been submitted before.

You are right, I can't reproduce comment 0.
 
So what happens for me is that no matter what option I select for the layout, it always prints (or creates a pdf) as the first option and not the page layout I select. My feeling is that with having both options selected (when going back) maybe the cause of this, which is what you just fixed.

If I change the page orientation, the page layout selected changes to the first option. Even if I had it selected as custom or 10x15. Are you saying that if I had selected 10x15 that it should stay selected if I change the page orientation?

Would I have to wait for a new beta build of 5.9 for this fix?
Comment 8 Maik Qualmann 2018-03-01 20:19:55 UTC
If you are using a custom photo layout, this is actually always reset to the first entry in the list, it is programmed in the code. Why can not I tell you at the moment which side effect it might otherwise have. I will check it.

Maik
Comment 9 rob 2018-03-06 14:40:46 UTC
Sorry for the delay in replying. I had tried to build digikam myself and installing all the dependencies I messed up my linux installation.

I have installed the new build of 5.9 and it fixed my the problem. Thanks for being so quick with it.