Bug 388295 - CMake doesn't warn if Flatpak dev packages aren't installed
Summary: CMake doesn't warn if Flatpak dev packages aren't installed
Status: VERIFIED FIXED
Alias: None
Product: Discover
Classification: Applications
Component: discover (show other bugs)
Version: 5.11.4
Platform: Other Linux
: NOR normal
Target Milestone: ---
Assignee: Aleix Pol
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2017-12-28 16:03 UTC by Nate Graham
Modified: 2017-12-28 16:34 UTC (History)
0 users

See Also:
Latest Commit: https://commits.kde.org/discover/01deaa8cf7b89725c3bc5b59fb8f58069e82774a
Version Fixed In:
Sentry Crash Report:

Attachments
Add an attachment

Note You need to log in before you can comment on or make changes to this bug.
Description Nate Graham 2017-12-28 16:03:18 UTC 
Discover's CMake doesn't currently warn if the Flatpak dev packages aren't installed (libflatpak-dev on Ubuntu-based distros); instead it silently doesn't build the Flatpak backend libraries.
Comment 1 Aleix Pol 2017-12-28 16:24:21 UTC 
Git commit 01deaa8cf7b89725c3bc5b59fb8f58069e82774a by Aleix Pol.
Committed on 28/12/2017 at 16:20.
Pushed by apol into branch 'master'.

Warn if building flatpak is enabled but some dependencies aren't found

M  +5    -0    CMakeLists.txt
M  +2    -0    libdiscover/backends/CMakeLists.txt

https://commits.kde.org/discover/01deaa8cf7b89725c3bc5b59fb8f58069e82774a
Comment 2 Nate Graham 2017-12-28 16:34:56 UTC 
Confirmed, thanks for the super quick fix!