Bug 388183 - Windows installer is not HiDPI ready
Summary: Windows installer is not HiDPI ready
Status: RESOLVED FIXED
Alias: None
Product: digikam
Classification: Applications
Component: Bundle-Windows (other bugs)
Version First Reported In: 5.7.0
Platform: Microsoft Windows Microsoft Windows
: NOR normal
Target Milestone: ---
Assignee: Digikam Developers
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2017-12-23 22:44 UTC by uwestoehr
Modified: 2017-12-26 23:05 UTC (History)
1 user (show)

See Also:
Latest Commit:
Version Fixed/Implemented In: 5.8.0
Sentry Crash Report:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description uwestoehr 2017-12-23 22:44:38 UTC
The Win installer of digiKam 5.7 looks blurred on HiDPI screens. The reason is that it uses the old NSIS 2.5.

To fix this bug, simply upgrade to NSIS 3.x and use the new command ManifestDPIAware:
http://nsis.sourceforge.net/Reference/ManifestDPIAware

p.s. NSIS 3.x comes with full Unicode support.
Comment 1 caulier.gilles 2017-12-24 07:00:28 UTC
The new 5.8.0 bundle use already NSIS 3.x. So it will not a problem to patch the option for Hdpi support.

See here : https://files.kde.org/digikam/

Gilles Caulier
Comment 2 caulier.gilles 2017-12-24 07:24:23 UTC
Git commit a2e99b0cf9d6c6452905446388918855d1bcfc9e by Human Dynamo.
Committed on 24/12/2017 at 07:23.
Pushed by cgilles into branch 'master'.

add support of hdpi screens with NSI 3.x
FIXED-IN: 5.8.0

M  +4    -1    project/bundles/mxe/installer/digikam.nsi

https://commits.kde.org/digikam-software-compilation/a2e99b0cf9d6c6452905446388918855d1bcfc9e
Comment 3 uwestoehr 2017-12-24 15:34:07 UTC
Many thanks for the quick fix.

I am sorry that I used digiKam 5.7 to report bugs. You linked me to 5.8 but on the digiKam website still 5.7 is advertised as the latest version.
Comment 4 caulier.gilles 2017-12-24 16:43:02 UTC
The link is the pre release 5.8.0 not yet published officially.

Gilles Caulier
Comment 5 caulier.gilles 2017-12-26 17:07:36 UTC
Question about UTF8 support with nsis 3: what’s the gain to enable this s option in build script ?
Comment 6 uwestoehr 2017-12-26 19:15:06 UTC
> Question about UTF8 support with nsis 3: what’s the gain to enable this s
> option in build script ?

I provide the Win installer for the program LyX (lyx.org) and can now directly use e.g. Cyrillic letters in the installer text. The installer is translated to different languages including RTL languages like Arabic. The Unicode support of NSIS 3 allows to display correct Arabic script for the first time.
Comment 7 caulier.gilles 2017-12-26 23:05:21 UTC
Git commit a3811028081e91c81ce4d9000f48f5e1d68ac1a3 by Human Dynamo.
Committed on 24/12/2017 at 18:18.
Pushed by cgilles into branch 'master'.

enable UTF8 support

M  +1    -1    project/bundles/mxe/config.sh
M  +1    -1    project/bundles/mxe/installer/README
M  +3    -0    project/bundles/mxe/installer/digikam.nsi
M  +1    -1    project/bundles/mxe/installer/events_functions.nsh
M  +1    -1    project/bundles/mxe/installer/process_running.nsh
M  +1    -1    project/bundles/mxe/installer/readme_page.nsh
M  +1    -1    project/bundles/mxe/installer/reboot_required.nsh

https://commits.kde.org/digikam-software-compilation/a3811028081e91c81ce4d9000f48f5e1d68ac1a3