networkingclient shows state change of the related test app networkingservice. On windows networkingclient does not show the state changes. This issue may affect other applications depending on kdelibs4support.
Running the networkingclient prints out the following message: [384] Warning:QObject::connect: No such slot solid::NetworkingPrivate::serviceStatusChanged(bool) which seems to be created by the following code fragment located in src/solid/networking_p.h #ifndef Q_OS_WIN /** * Called on DBus signal from the network status service */ void serviceStatusChanged(uint status); #else void serviceStatusChanged(bool status); #endif Because moc does not define Q_OS_WIN a signal with uint type is generated and therefore related connection fails -> need to to define Q_OS_WIN on running moc on Windows.
(In reply to Ralf Habacker from comment #1) > Running the networkingclient prints out the following message: > > [384] Warning:QObject::connect: No such slot > solid::NetworkingPrivate::serviceStatusChanged(bool) fixed with https://phabricator.kde.org/D9468?vs=24256&id=25088&whitespace=ignore-most#toc
See https://phabricator.kde.org/D9468 for the related review request
Code review from comment #3 says it is committed. Anything else needed for resolving this ticket?
(In reply to Ralf Habacker from comment #3) > See https://phabricator.kde.org/D9468 for the related review request The patch from the mentioned review was submitted with commit https://phabricator.kde.org/R239:1d1af3e514071efc51281b7ac1154737e44aa224
(In reply to Christoph Feck from comment #4) > Code review from comment #3 says it is committed. Anything else needed for > resolving this ticket? I need to check that next time I'm coming back to kdelib4support.