Bug 388129 - Focus filter locking is not working
Summary: Focus filter locking is not working
Status: RESOLVED FIXED
Alias: None
Product: kstars
Classification: Applications
Component: general (show other bugs)
Version: 2.8.9
Platform: Ubuntu Linux
: NOR normal
Target Milestone: ---
Assignee: Jasem Mutlaq
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2017-12-21 23:29 UTC by Paul
Modified: 2017-12-22 11:59 UTC (History)
0 users

See Also:
Latest Commit:
Version Fixed In: 2.9.0
Sentry Crash Report:


Attachments
Screen dump showing settings (126.53 KB, image/png)
2017-12-21 23:29 UTC, Paul
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Paul 2017-12-21 23:29:28 UTC
Created attachment 109478 [details]
Screen dump showing settings

I need to focus using a luminance filter but image using a Hydrogen Alpha filter. This is because I have never been able to get focusing working through the Hydrogen Alpha filter because of the noise levels.

When I set this up and it focuses between images it should be using the Luminance filter but it never works. Instead each image gets more and more out of focus. Because the image does not get reflected in the focus modeule it is not obvious what is happening. It appears from my testing that it must be using the Hydrogen Alpha filter instead and focusing on noise.
Comment 1 Jasem Mutlaq 2017-12-22 10:05:23 UTC
This is NOT the correct settings for the case you described. Please read documentation here: https://stellarmate.com/support/ekos/capture.html

For your case, you need to set the LOCKED filter of H to L. I found other issues as well that should be fixed in 2.9.0
Comment 2 Jasem Mutlaq 2017-12-22 10:07:47 UTC
Git commit 38fc2326f33e37d11d324741f34c93d985802b0f by Jasem Mutlaq.
Committed on 22/12/2017 at 10:06.
Pushed by mutlaqja into branch 'master'.

Remove lock policy from filter manager and let focus module handle it as it reduces complexity and fixes some corner issues.
FIXED-IN:2.9.0

M  +8    -45   kstars/ekos/auxiliary/filtermanager.cpp
M  +3    -6    kstars/ekos/auxiliary/filtermanager.h
M  +1    -1    kstars/ekos/capture/sequencejob.cpp
M  +20   -1    kstars/ekos/focus/focus.cpp
M  +2    -0    kstars/ekos/focus/focus.h

https://commits.kde.org/kstars/38fc2326f33e37d11d324741f34c93d985802b0f
Comment 3 Paul 2017-12-22 11:59:46 UTC
Jasem,

Thanks for your patience, my interpretation was the ‘L’ meant locked and now I understand how it works and it is working.

Regards

Paul

> On 22 Dec 2017, at 9:05:23 pm, Jasem Mutlaq <bugzilla_noreply@kde.org> wrote:
> 
> https://bugs.kde.org/show_bug.cgi?id=388129
> 
> --- Comment #1 from Jasem Mutlaq <mutlaqja@ikarustech.com> ---
> This is NOT the correct settings for the case you described. Please read
> documentation here: https://stellarmate.com/support/ekos/capture.html
> 
> For your case, you need to set the LOCKED filter of H to L. I found other
> issues as well that should be fixed in 2.9.0
> 
> -- 
> You are receiving this mail because:
> You reported the bug.