Bug 388126 - Apply/discard prompt appears when the user tries to close system settings immediately after close GHNS window without to do any change
Summary: Apply/discard prompt appears when the user tries to close system settings imm...
Status: RESOLVED FIXED
Alias: None
Product: kde-gtk-config
Classification: Plasma
Component: general (show other bugs)
Version: 5.15.0
Platform: Arch Linux Linux
: NOR normal
Target Milestone: ---
Assignee: Manuel Tortosa
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2017-12-21 19:30 UTC by Patrick Silva
Modified: 2019-03-05 02:40 UTC (History)
2 users (show)

See Also:
Latest Commit:
Version Fixed In:


Attachments
demonstration (969.98 KB, video/webm)
2017-12-22 01:58 UTC, Patrick Silva
Details
video recorded on Plasma 5.15.2 (3.16 MB, video/webm)
2019-03-05 02:15 UTC, Patrick Silva
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Patrick Silva 2017-12-21 19:30:16 UTC
summary says by itself.
reproducible on Arch Linux and neon dev unstable.
Comment 1 Aleix Pol 2017-12-22 01:27:20 UTC
Can you take a video or something? It would help understand.
Comment 2 Patrick Silva 2017-12-22 01:58:27 UTC
Created attachment 109480 [details]
demonstration

ok, watch the screencast recorded on neon.
Comment 3 Tony 2017-12-26 22:44:44 UTC
That's how it works. If you close the gtk/style window after you've done any change that dialog box will pop asking you if you want to apply the changes or discard them. Is the same all around systemsettings.

Your gtk theme is downloaded but not applied unless you confirm to do so in the prompt.
Comment 4 Patrick Silva 2017-12-27 01:08:48 UTC
(In reply to Tony from comment #3)
> Your gtk theme is downloaded but not applied unless you confirm to do so in
> the prompt.

So we have another bug because the just installed gtk theme is not applied when I click "Apply" button. On Arch Linux at least.
Comment 5 Aleix Pol 2018-02-08 17:30:10 UTC
Git commit 54d8e029422e30e7197fe40e35ff4c6345f6962c by Aleix Pol.
Committed on 08/02/2018 at 17:29.
Pushed by apol into branch 'Plasma/5.12'.

Make sure there are less unnecessary changed() emissions

M  +64   -8    src/gtkconfigkcmodule.cpp
M  +1    -0    src/gtkconfigkcmodule.h

https://commits.kde.org/kde-gtk-config/54d8e029422e30e7197fe40e35ff4c6345f6962c
Comment 6 Patrick Silva 2018-02-13 18:52:47 UTC
plasma 5.12.1 changelog says that this bug is fixed, but it's still reproducible on Arch Linux.
Comment 7 Patrick Silva 2018-06-12 16:29:23 UTC
Reproducible with plasma 5.13 on Arch Linux.
Comment 8 Patrick Silva 2018-11-16 20:26:52 UTC
it's not necessary to install a gtk 2/3 theme.
Just click "Get new themes" button, click "Download gtk2 themes" or
"Download gtk3 themes", so "Get hot new stuff" (GHNS) window shows up.
Close GHNS window, close system settings, so Apply/discard prompt appears.
Comment 9 Aleix Pol 2019-03-05 01:45:07 UTC
I really cannot reproduce.

On that video, the apply button is already enabled when the video starts playing, I can't see which event triggers the changed signal.
Comment 10 Patrick Silva 2019-03-05 02:15:30 UTC
Created attachment 118554 [details]
video recorded on Plasma 5.15.2

hum, really my first video is total crap. Sorry.
Here is another screen recording.
Comment 11 Aleix Pol 2019-03-05 02:19:51 UTC
That crash is something different though. It's actually 398112 which as I just fixed as of 1bdaa7db43f2645ff1e4607545048f4eb395e26d.

Can you please confirm?
Comment 12 Patrick Silva 2019-03-05 02:40:47 UTC
Hum, really the issue shown in my second video looks the same as bug 398112 just fixed by you.
Probably I got confused and the original problem reported here was fixed
by your commit from comment 5. Sorry.
I'm closing this report as fixed.

Thanks Aleix.