Bug 388102 - A few Application Page toolbar icons lost their padding in 309703c87b62cb97e20be19338467969cd8151c0
Summary: A few Application Page toolbar icons lost their padding in 309703c87b62cb97e2...
Status: RESOLVED FIXED
Alias: None
Product: Discover
Classification: Applications
Component: discover (show other bugs)
Version: 5.11.4
Platform: Other Linux
: NOR normal
Target Milestone: ---
Assignee: Aleix Pol
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2017-12-21 02:57 UTC by Nate Graham
Modified: 2017-12-28 17:47 UTC (History)
0 users

See Also:
Latest Commit:
Version Fixed In:
Sentry Crash Report:


Attachments
Applicatino Page toolbar items that lost their padding (212.84 KB, image/png)
2017-12-21 02:57 UTC, Nate Graham
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Nate Graham 2017-12-21 02:57:26 UTC
In 309703c87b62cb97e20be19338467969cd8151c0, banners were made smaller. However there were a few visual regressions with the application page toolbar. The back button lost its left padding, and the application icon lost its bottom padding. See attached screenshot.
Comment 1 Nate Graham 2017-12-21 02:57:46 UTC
Created attachment 109467 [details]
Applicatino Page toolbar items that lost their padding
Comment 2 Aleix Pol 2017-12-28 14:29:07 UTC
Git commit d30f9ce9e444f199171ab6d7c301e3d6f161c5c7 by Aleix Pol.
Committed on 28/12/2017 at 14:20.
Pushed by apol into branch 'master'.

Add margins on the application page header

M  +5    -2    discover/qml/ApplicationPage.qml

https://commits.kde.org/discover/d30f9ce9e444f199171ab6d7c301e3d6f161c5c7
Comment 3 Nate Graham 2017-12-28 16:22:08 UTC
Close! That commit fixed the bottom margin issue for app icons, but not the lack of a left margin for the back button.
Comment 4 Nate Graham 2017-12-28 17:47:32 UTC
https://cgit.kde.org/discover.git/commit/?id=c8d5c23de57ca653d4442f8369b72251410e028b seems to have fixed that case, too.