Bug 388060 - Exec line in kpasswdserver service file must not have any path prefix on Windows
Summary: Exec line in kpasswdserver service file must not have any path prefix on Windows
Status: RESOLVED FIXED
Alias: None
Product: frameworks-kio
Classification: Frameworks and Libraries
Component: general (show other bugs)
Version: 5.41.0
Platform: Other Microsoft Windows
: NOR normal
Target Milestone: ---
Assignee: David Faure
URL:
Keywords:
Depends on:
Blocks: 380136
  Show dependency tree / graph
 
Reported: 2017-12-20 10:12 UTC by Ralf Habacker
Modified: 2018-04-04 10:19 UTC (History)
2 users (show)

See Also:
Latest Commit: https://commits.kde.org/kio/105cdd8fb3c433588f799c901dd32ceb99b2cf11
Version Fixed In: 5.43.0
Sentry Crash Report:

Attachments
Add an attachment

Note You need to log in before you can comment on or make changes to this bug.
Description Ralf Habacker 2017-12-20 10:12:57 UTC 
cat ./src/kpasswdserver/org.kde.kpasswdserver.service.in 
[D-BUS Service]
Name=org.kde.kpasswdserver
Exec=@KDE_INSTALL_FULL_LIBEXECDIR@/kf5/kiod5

shows that Exec line contains a path prefix which does not work on Windows (see bug 382458 for details)

Instead the prefix in the Exec line needs to be completly removed on windows e.g.

Exec=kiod5
Comment 1 Ralf Habacker 2017-12-20 11:00:26 UTC 
review request https://phabricator.kde.org/D9427
Comment 2 Ralf Habacker 2018-01-07 18:16:17 UTC 
Git commit 105cdd8fb3c433588f799c901dd32ceb99b2cf11 by Ralf Habacker.
Committed on 07/01/2018 at 18:15.
Pushed by habacker into branch 'master'.

Use cmake function 'kdbusaddons_generate_dbus_service_file' from kdbusaddons to generate dbus service file

Summary:
Related: bug 382459, bug 388059, bug 388062, bug 388063
FIXED-IN:5.43.0

Test Plan:
compiled against installed HEAD of kdbusaddons git master branch and inspected generated service files;
On Windows only the executable is used, which is expected

Reviewers: dfaure, kfunk, bcooksley

Reviewed By: dfaure

Subscribers: #frameworks

Tags: #frameworks

Differential Revision: https://phabricator.kde.org/D9669

M  +1    -2    src/ioslaves/http/kcookiejar/CMakeLists.txt
D  +0    -4    src/ioslaves/http/kcookiejar/org.kde.kcookiejar5.service.in
M  +1    -4    src/kiod/CMakeLists.txt
D  +0    -4    src/kiod/org.kde.kiod5.service.in
M  +1    -2    src/kioexec/CMakeLists.txt
D  +0    -3    src/kioexec/org.kde.kioexecd.service.in
M  +1    -2    src/kpasswdserver/CMakeLists.txt
D  +0    -4    src/kpasswdserver/org.kde.kpasswdserver.service.in
M  +1    -2    src/kssld/CMakeLists.txt
D  +0    -4    src/kssld/org.kde.kssld5.service.in

https://commits.kde.org/kio/105cdd8fb3c433588f799c901dd32ceb99b2cf11