The latest changes occurring in the Breeze-GTK+ repository (16th December 2017) cause major visual artifacts in some GTK+-using programs, especially Firefox: - No text highlight (selecting text does not show anything) - Missing radio buttons in forms - Menu items are cramped next to each other Reverting to the previous commit (27th November) fixes the issues completely. I suspect a problem with the new generator that was included in the repository. I will try to provide screenshots for this issue as soon as I can.
Created attachment 109443 [details] Issue as shown in openQA OpenQA also caught this issue: as you can see from the image, the button borders are missing and so is the checkbox.
Thank you for your detailed report. I can't seem to reproduce this issue with Firefox 57, nor can I see the highlight/form/menu items issue in Firefox or other GTK applications. This may be related to your GTK version, as GTK versions prior to 3.18 are no longer supported. Still, that may not be the case as the November 27th version would've caused more problems as it only supported GTK 3.20 onward. However, I am doubtful it's related to the theme generator since those changes only apply to assets for now and the scrollbars are the only assets that were different in the update, fixing some visual artifacts as well as improving maintainability. Changes to highlights and menu items in particular can't be affected by the raster images, only by the CSS. Still, I would certainly like to reproduce this issue, so if you could give me more information about the distribution and version where you encountered the issue and if you have any non-default repositories enabled, that would be very helpful in pinning down the cause. If it's related to GTK 3.16 after all, this distro should continue using the previous Plasma version's Breeze GTK package rather than backporting the upcoming release. If it's related to GTK 3.18, however, there may be more we can do about it.
The distribution is openSUSE Tumbleweed, which uses a fairly recent GTK+ version (3.22). The screenshot you saw is the product of an automated test which always creates user configuration from scratch, so I would exclude the effect of pre-existing configuration.
Git commit 50c632cfa9b991c6729bc561405214b98f6c5feb by Luca Beltrame. Committed on 20/12/2017 at 14:32. Pushed by lbeltrame into branch 'master'. Revert "Revert "Remove gtk+-3 build dep, install versioned gtk.css dirs unconditionally"" This reverts commit 89ebc0b7e167f25af96c72d87f1a416820424e1f. Same as previous commit, causes theme installation issues. CCMAIL: bcooksley@kde.org M +3 -5 Breeze-dark-gtk/CMakeLists.txt M +3 -5 Breeze-gtk/CMakeLists.txt M +0 -3 CMakeLists.txt https://commits.kde.org/breeze-gtk/50c632cfa9b991c6729bc561405214b98f6c5feb
Somehow part of the CC didn't get here... It's fixed by 4757d48d7f97d354f1ad926b9999bbc5ae06aa51 in breeze-gtk, which restores the ability to install themes correctly (which was the case all along - the wrong theme would get installed).
Thanks for finding the root of the issue and taking care of it. Lending a hand like this is always appreciated.