This is not a bug, just a sideline change that cleans up some code. The patch is already a bit old, so it might not merge cleanly with master anymore. I will fix this if this is considered for merging.
Created attachment 110539 [details] remove unused KIO legacy and polish drag&drop mime Gilles proposed to delay that to 6.0.0. Now that this branch exists, am I good to go to commit this patch?
yes, it's fine, if : 1/ all the code compile. We must support Qt 5.6 LTS, don't remember. 2/ digiKam start and run without any broken signal/slots connections at run-time. Check well... After last 5.9.0 to release in few week, we will branch 6.0.0 branch to master and propose first bundle to test. 6.0.0 beta series are planed, at least until the end of summer, not before. Gilles
Simon, We are now in 6.0.0 devel stage. It's the good time to update your patch...
Created attachment 112613 [details] remove unused KIO legacy and polish drag&drop mime I updated the patch to master -> good to commit now?
I read well the patch, and it's sound fine for me. But i would to see if Maik is agree with these changes as he currently work on DIO area, and this can have side effects. Anyway, yes, this patch must be integrate definitively before 6.0.0 final release. Gilles
Yes, Simon commit this patch. Maik
Simon, I think we can close the bug? Maik
Git commit e06a6e027de0c296575776359123bb757888420b by Simon Frei. Committed on 13/05/2018 at 19:19. Pushed by sfrei into branch 'master'. Update NEWS FIXED-IN: 6.0.0 M +2 -1 NEWS https://commits.kde.org/digikam/e06a6e027de0c296575776359123bb757888420b