Bug 387988 - Folder view should not allow duplicated file deletion dialog
Summary: Folder view should not allow duplicated file deletion dialog
Status: CONFIRMED
Alias: None
Product: plasmashell
Classification: Plasma
Component: Folder (show other bugs)
Version: 5.27.4
Platform: Arch Linux Linux
: NOR normal
Target Milestone: 1.0
Assignee: Eike Hein
URL:
Keywords: usability
Depends on:
Blocks:
 
Reported: 2017-12-17 13:46 UTC by Patrick Silva
Modified: 2023-05-08 19:51 UTC (History)
4 users (show)

See Also:
Latest Commit:
Version Fixed In:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Patrick Silva 2017-12-17 13:46:42 UTC
set your desktop to folder view
select a folder and press shift+delete (delete dialog appears)
click on the same folder and press shift+delete again
Result: one more delete dialog appears
Comment 1 Nate Graham 2017-12-17 13:56:34 UTC
Can confirm with Plasma 5.11.4 on Kubuntu 17.10. The dialog isn't modal, and initiating a second delete action opens a new dialog instead of bringing focus to the current one.
Comment 2 capitaine.kirk 2018-01-23 06:13:22 UTC
confirmed on my Kubuntu 17.10. another dialog appears instead of bringing back the focus on the current one.
Comment 3 Méven Car 2019-05-31 08:34:21 UTC
The issue boils down to library KIO::JobUiDelegate not supporting QWindow as parent window, but requiring a QWidget instead, but since the folder view is in QtQuick/QML land that is not possible from there.
We need to make KIO::JobUiDelegate and KMessageBox work with QWindow to fix this properly.

Maybe wait to make a a library breakage : changing :

KIO::JobUiDelegate::setWindow(Qwidget *window) to 

KIO::JobUiDelegate::setWindow(QWindow *window)

Which should be easy for users to port, since QWidget has a nice windowHandle function to get any QWigets parent window.

Removing junior-job as library work is not an easy path for first contribution.