Bug 387912 - Broken link to omg.org/spec in "About->Umbrello" dialog
Summary: Broken link to omg.org/spec in "About->Umbrello" dialog
Status: RESOLVED FIXED
Alias: None
Product: umbrello
Classification: Applications
Component: general (show other bugs)
Version: 2.23.3 (KDE Applications 17.08.3)
Platform: Compiled Sources Linux
: NOR normal
Target Milestone: ---
Assignee: Umbrello Development Group
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2017-12-14 19:22 UTC by Robert Hairgrove
Modified: 2017-12-14 21:05 UTC (History)
0 users

See Also:
Latest Commit: https://commits.kde.org/umbrello/c74304cb27f71bedf7d5505f0abb64e8a5a5e6d0
Version Fixed In: 2.24.1 (KDE Applications 17.12.1)

Attachments
Add an attachment

Note You need to log in before you can comment on or make changes to this bug.
Description Robert Hairgrove 2017-12-14 19:22:20 UTC 
On Ubuntu 16.04 from the most recent compiled sources:

Clicking on the link to http://www.omg.org/spec/ will not open my default browser. If I copy/paste the link manually, I see single quotes are surrounding the URL.

Look at line 110 in main.cpp ... you will see why:

```
    KAboutData aboutData(QStringLiteral("umbrello"),
                         i18n("Umbrello UML Modeller"),
                         QLatin1String(umbrelloVersion()),
                         i18n("Umbrello – Visual development environment for software, "
                              "based on the industry standard Unified Modelling Language (UML).<br/>"
                              "See also <a href=’http://www.omg.org/spec/’>http://www.omg.org/spec/</a>."),
                         //                     ^                        ^
                         KAboutLicense::GPL,
                         i18n("Copyright © 2001 Paul Hensgen,\nCopyright © 2002-2016 Umbrello UML Modeller Authors"),
                         QString(),
                         QStringLiteral("http://umbrello.kde.org"));
```

Seems to me that one should write backslash-escaped double quotes here.
Comment 1 Robert Hairgrove 2017-12-14 19:24:36 UTC 
I see now that the single quotes are actually "fancy" quotes. Maybe that is the reason?
Comment 2 Ralf Habacker 2017-12-14 21:05:50 UTC 
Git commit c74304cb27f71bedf7d5505f0abb64e8a5a5e6d0 by Ralf Habacker.
Committed on 14/12/2017 at 20:56.
Pushed by habacker into branch 'Applications/17.12'.

Fix 'Broken link to omg.org/spec in "About->Umbrello" dialog'
FIXED-IN:2.24.1 (KDE Applications 17.12.1)

M  +1    -1    umbrello/main.cpp

https://commits.kde.org/umbrello/c74304cb27f71bedf7d5505f0abb64e8a5a5e6d0