Bug 387862 - argument truncation warning in CartesianPlot
Summary: argument truncation warning in CartesianPlot
Status: RESOLVED FIXED
Alias: None
Product: LabPlot2
Classification: Applications
Component: backend (show other bugs)
Version: latest
Platform: Microsoft Windows Microsoft Windows
: NOR normal
Target Milestone: ---
Assignee: Alexander Semke
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2017-12-13 03:18 UTC by Uwe Stöhr
Modified: 2017-12-15 07:43 UTC (History)
0 users

See Also:
Latest Commit:
Version Fixed In: 2.5


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Uwe Stöhr 2017-12-13 03:18:47 UTC
I get:

3>C:\CraftRoot\labplot\src\backend\worksheet\plots\cartesian\CartesianPlot.cpp(2895): warning C4838: conversion from 'double' to 'float' requires a narrowing conversion
3>C:\CraftRoot\labplot\src\backend\worksheet\plots\cartesian\CartesianPlot.cpp(2895): warning C4305: 'initializing': truncation from 'double' to 'float'
Comment 1 Alexander Semke 2017-12-14 22:37:29 UTC
Git commit e23d0e36481f62c4f8da0f4bfbb3b22492d2bc95 by Alexander Semke.
Committed on 14/12/2017 at 22:36.
Pushed by asemke into branch 'master'.

Removed implicit conversion from double to float in CartesianPlot.
FIXED-IN: 2.5

M  +1    -1    src/backend/worksheet/plots/cartesian/CartesianPlot.cpp

https://commits.kde.org/labplot/e23d0e36481f62c4f8da0f4bfbb3b22492d2bc95
Comment 2 Uwe Stöhr 2017-12-14 23:31:36 UTC
Now I get:

1>C:\CraftRoot\labplot\src\backend\worksheet\plots\cartesian\CartesianPlot.cpp(1310): warning C4456: declaration of 'curve' hides previous local declaration
1>  C:\CraftRoot\labplot\src\backend\worksheet\plots\cartesian\CartesianPlot.cpp(1302): note: see declaration of 'curve'
1>C:\CraftRoot\labplot\src\backend\worksheet\plots\cartesian\CartesianPlot.cpp(1335): warning C4456: declaration of 'curve' hides previous local declaration
1>  C:\CraftRoot\labplot\src\backend\worksheet\plots\cartesian\CartesianPlot.cpp(1328): note: see declaration of 'curve'
Comment 3 Alexander Semke 2017-12-15 07:43:14 UTC
Git commit 0544f6c20e28ff84008e2c56821964db1a101c45 by Alexander Semke.
Committed on 15/12/2017 at 07:41.
Pushed by asemke into branch 'master'.

1. properly set the name of Origin matrix sheets during the import
2. fixed couple of warnings
Related: bug 387860
FIXED-IN:2.5

M  +6    -8    src/backend/datasources/projects/OriginProjectParser.cpp
M  +4    -7    src/backend/worksheet/plots/cartesian/CartesianPlot.cpp

https://commits.kde.org/labplot/0544f6c20e28ff84008e2c56821964db1a101c45