Bug 387819 - Screenshot pop-up has an extra margin on the side or top if window dimensions aren't just right
Summary: Screenshot pop-up has an extra margin on the side or top if window dimensions...
Status: VERIFIED FIXED
Alias: None
Product: Discover
Classification: Applications
Component: discover (show other bugs)
Version: 5.11.4
Platform: Ubuntu Linux
: NOR normal
Target Milestone: ---
Assignee: Aleix Pol
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2017-12-12 04:26 UTC by Nate Graham
Modified: 2018-01-03 15:33 UTC (History)
0 users

See Also:
Latest Commit:
Version Fixed In:
Sentry Crash Report:


Attachments
Extra margin on side and top when window is very wide or somewhat tall (2.25 MB, video/webm)
2017-12-12 04:26 UTC, Nate Graham
Details
Now screenshows are never scaled down to match the window width (350.93 KB, image/png)
2017-12-29 14:33 UTC, Nate Graham
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Nate Graham 2017-12-12 04:26:06 UTC
Created attachment 109330 [details]
Extra margin on side and top when window is very wide or somewhat tall

When the screenshot pop-up is open, if the window dimensions aren't exactly right, there is an extra margin on either the side or the top. The screen recording I've attached illustrates the problem better than I can explain it.

This is pretty easy to see if the window is taller than it is wide, since most screenshots are in the landscape orientation.
Comment 1 Nate Graham 2017-12-20 23:27:15 UTC
Looks fixed as of the recent screenshot pop-up improvements.
Comment 2 Nate Graham 2017-12-28 20:57:40 UTC
Nah sorry, seeing this again with current git master.
Comment 3 Aleix Pol 2017-12-29 14:10:34 UTC
Git commit 4efed77684fc0fca8d26a6e9076a3a3d3b634dd3 by Aleix Pol.
Committed on 29/12/2017 at 14:06.
Pushed by apol into branch 'master'.

Don't show white space around the screenshot when it doesn't fit

M  +2    -1    discover/qml/ApplicationScreenshots.qml

https://commits.kde.org/discover/4efed77684fc0fca8d26a6e9076a3a3d3b634dd3
Comment 4 Nate Graham 2017-12-29 14:33:45 UTC
Created attachment 109579 [details]
Now screenshows are never scaled down to match the window width

Well that fixed the top margin issue, but now screenshots are never scaled down to match the window width.
Comment 5 Aleix Pol 2017-12-29 15:30:29 UTC
Git commit 0c2db42b943380782cc3c338902b2c16d098036e by Aleix Pol.
Committed on 29/12/2017 at 15:26.
Pushed by apol into branch 'master'.

Also take width into account

M  +1    -1    discover/qml/ApplicationScreenshots.qml

https://commits.kde.org/discover/0c2db42b943380782cc3c338902b2c16d098036e
Comment 6 Nate Graham 2018-01-03 15:33:57 UTC
Thanks, works great now!