Bug 387761 - errorText is empty when moving or copying file to a location without free space, leading to an unnecessary space in the "disk full" message.
Summary: errorText is empty when moving or copying file to a location without free spa...
Status: RESOLVED FIXED
Alias: None
Product: frameworks-kio
Classification: Frameworks and Libraries
Component: general (other bugs)
Version First Reported In: 5.48.0
Platform: Other Linux
: NOR normal
Target Milestone: ---
Assignee: David Faure
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2017-12-10 08:53 UTC by Patrick Silva
Modified: 2018-10-15 16:27 UTC (History)
4 users (show)

See Also:
Latest Commit:
Version Fixed/Implemented In:
Sentry Crash Report:

Attachments
screenshot (16.83 KB, image/png)
2017-12-10 08:53 UTC, Patrick Silva 		Details
View All Add an attachment

Note You need to log in before you can comment on or make changes to this bug.
Description Patrick Silva 2017-12-10 08:53:24 UTC 
Created attachment 109285 [details]
screenshot

try copy/move data to a location without enough free space
a red bar appears in dolphin, its content contains unncessary space before one of the periods. See my screenshot.
Comment 1 Nate Graham 2017-12-11 14:02:18 UTC 
This is in kio/src/core/job_error.cpp. The error message is doing this:

result = i18n("Could not write file %1.\nDisk full.",  errorText);

So when errorText is empty, there will be an extra space. The bigger question may be why errorText is empty in the first place.
Comment 2 Patrick Silva 2018-10-15 15:55:52 UTC 
cannot reproduce on Arch Linux after upgrade to frameworks 5.51.
Comment 3 Nate Graham 2018-10-15 16:19:28 UTC 
Hah, this was fixed incidentally as a part of some other thing I did recently.
Comment 4 Patrick Silva 2018-10-15 16:25:15 UTC 
Awesome hehe.
Thank you Nate.
Comment 5 Nate Graham 2018-10-15 16:27:22 UTC 
You're very welcome!