Bug 387757 - Color manage pick() method of org.kde.kwin.ColorPicker
Summary: Color manage pick() method of org.kde.kwin.ColorPicker
Alias: None
Product: kwin
Classification: Plasma
Component: effects-various (show other bugs)
Version: unspecified
Platform: Other Linux
: NOR wishlist
Target Milestone: ---
Assignee: KWin default assignee
Depends on:
Reported: 2017-12-10 01:58 UTC by Jehan
Modified: 2023-10-14 14:22 UTC (History)
1 user (show)

See Also:
Latest Commit:
Version Fixed In: 6.0


Note You need to log in before you can comment on or make changes to this bug.
Description Jehan 2017-12-10 01:58:40 UTC
We need to be able to convert the picked pixel into the sRGB color space in case the screen is color-managed.

Through the dbus API, we don't even know the pixel coordinates (so in multi-display setups, we could not know for sure which is the right profile to get anyway); and in any case, I'm not sure if we can get the display profiles in Wayland (well at least right now our code doesn't have the implementation).

The "pick" method needs to return a converted color or the monitor profile it is displayed with so that we can convert ourselves or apply it.

See: https://bugzilla.gnome.org/show_bug.cgi?id=779942#c5
Comment 1 Bug Janitor Service 2023-10-10 11:51:42 UTC
A possibly relevant merge request was started @ https://invent.kde.org/plasma/kwin/-/merge_requests/4486
Comment 2 Zamundaaa 2023-10-14 12:03:15 UTC
Git commit f8012f580bb3d4782ce3d612793a7763cff06270 by Xaver Hugl.
Committed on 14/10/2023 at 13:55.
Pushed by zamundaaa into branch 'master'.

plugins/colorpicker: convert picked color to sRGB

The API doesn't have any colorspace data, so we need to make sure we're
sending sRGB

M  +44   -0    src/libkwineffects/colorspace.cpp
M  +2    -0    src/libkwineffects/colorspace.h
M  +2    -1    src/plugins/colorpicker/colorpicker.cpp