Bug 387590 - Contradicting touchpad enabled/disabled notification after mouse plugged in and out quickly
Summary: Contradicting touchpad enabled/disabled notification after mouse plugged in a...
Status: RESOLVED FIXED
Alias: None
Product: plasmashell
Classification: Plasma
Component: Notifications (show other bugs)
Version: 5.11.4
Platform: Neon Linux
: NOR normal
Target Milestone: 1.0
Assignee: Kai Uwe Broulik
URL:
Keywords: usability
Depends on:
Blocks:
 
Reported: 2017-12-04 15:02 UTC by Alexander Mentyu
Modified: 2019-05-28 14:06 UTC (History)
3 users (show)

See Also:
Latest Commit:
Version Fixed In: 5.16.0
Sentry Crash Report:


Attachments
controversy-notification-after-mouse-plugged-in (151.77 KB, image/png)
2017-12-04 15:02 UTC, Alexander Mentyu
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Alexander Mentyu 2017-12-04 15:02:04 UTC
Created attachment 109209 [details]
controversy-notification-after-mouse-plugged-in

Touchpad -> Enable/Disable Touchpad -> 'Disable touchpad when mouse is plugged in'. When for both events 'Touchpad was enabled' and 'Touchpad was disabled' - 'Show a message in a popup' action is set

Not sure 100% if this is a bug in this case - but i think it would be better to hide previous notification and display only current touchpad status in a single line notification - i.e. - when mouse was plugged in - display 'Touchpad was disabled' - and when mouse was quickly unplugged after that - hide previous notification and display 'Touchpad was enabled' notification - without any other previous statuses of the touchpad in the notification.
Comment 1 Kai Uwe Broulik 2018-05-16 07:21:24 UTC
It should either replace the existing notification or skip grouping
Comment 2 Kai Uwe Broulik 2019-05-28 14:06:38 UTC
Git commit 999b619bc5c87c4c0a08f97e3e422562b5f72fff by Kai Uwe Broulik.
Committed on 28/05/2019 at 14:05.
Pushed by broulik into branch 'Plasma/5.16'.

[Touchpad KCM] Revoke touchpad enabled/disabled notification before sending a new one
FIXED-IN: 5.16.0

Differential Revision: https://phabricator.kde.org/D21439

M  +5    -1    kcms/touchpad/src/kded/kded.cpp
M  +4    -0    kcms/touchpad/src/kded/kded.h

https://commits.kde.org/plasma-desktop/999b619bc5c87c4c0a08f97e3e422562b5f72fff